Update Screenshots to version 10.11.0

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ianbicking, Assigned: ianbicking)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox55 fixed, firefox56 fixed, firefox57 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
This change imports the most recent translations into the add-on
Assignee

Updated

2 years ago
Assignee: nobody → ianb
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8895444 [details]
Bug 1388805 - Export Screenshots 10.11.0 to Firefox;

https://reviewboard.mozilla.org/r/166640/#review171766

::: browser/extensions/screenshots/test/browser/browser_screenshots_ui_check.js:9
(Diff revision 1)
> -add_task(async function() {
> -  await promiseScreenshotsEnabled();
> +add_task(function*() {
> +  yield promiseScreenshotsEnabled();
>  
> -  registerCleanupFunction(async function() {
> -    await promiseScreenshotsReset();
> +  registerCleanupFunction(function* () {
> +    yield promiseScreenshotsReset();
>    });
>  
> -  await BrowserTestUtils.waitForCondition(
> +  yield BrowserTestUtils.waitForCondition(

Why these changes?
Comment hidden (mozreview-request)
Assignee

Comment 4

2 years ago
Oops, an export problem – I thought we had aligned Firefox and repository with this change, but I was mistaken. Removed from latest patch.

Comment 5

2 years ago
mozreview-review
Comment on attachment 8895444 [details]
Bug 1388805 - Export Screenshots 10.11.0 to Firefox;

https://reviewboard.mozilla.org/r/166640/#review171800
Attachment #8895444 - Flags: review?(dtownsend) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed
Autoland can't push this until all pending issues in MozReview are marked as resolved.
Flags: needinfo?(ianb)
Keywords: checkin-needed
Assignee

Updated

2 years ago
Flags: needinfo?(ianb)
Keywords: checkin-needed

Comment 7

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c77ccf0124c5
Export Screenshots 10.11.0 to Firefox; r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c77ccf0124c5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Assignee

Comment 9

2 years ago
Comment on attachment 8895444 [details]
Bug 1388805 - Export Screenshots 10.11.0 to Firefox;

Approval Request Comment
[Feature/Bug causing the regression]:
Added locales / translations

[User impact if declined]:
Some locales will be under-translated

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
No (SoftVision has looked at this version)

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Only affects locales and the related build files

[String changes made/needed]:
Translation happening outside of Firefox tree
Attachment #8895444 - Flags: approval-mozilla-beta?
Comment on attachment 8895444 [details]
Bug 1388805 - Export Screenshots 10.11.0 to Firefox;

Add more translations to screenshots, sounds low-risk, let's aim this at beta 3.
Attachment #8895444 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8895444 [details]
Bug 1388805 - Export Screenshots 10.11.0 to Firefox;

this also went to release (see bug 1389786 comment 13 and 14)
Attachment #8895444 - Flags: approval-mozilla-release+

Updated

2 years ago
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.