1388817 - AWFY task_info no longer contains output

Status: RESOLVED FIXED

(Testing Graveyard :: AWFY, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Beginning with https://arewefastyet.com/task_info.php?id=101190 the Output: section of the Task output is empty. https://arewefastyet.com/task_info.php?id=101189 is the last task which contains data in the Output: section.

This began sometime between 03:30 and 05:30 AM 2017-08-09 PT.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: https://github.com/mozilla/arewefastyet/pull/155

I think that we might be having an issue with the 302 Found response for http requests. We might as well convert them all to https and eliminate the possibility. If this fixes the issue, fine. If not, we can continue looking.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8895698 [details] [diff] [review]
https://github.com/mozilla/arewefastyet/pull/155

Review of attachment 8895698 [details] [diff] [review]:
-----------------------------------------------------------------

Merged on github, thanks!

We might need to make sure the value of updateURL in all the awfy.config files on the workers use HTTPS too (there's one per worker, located in the awfy directory, at "slave/awfy.config").

Comment 3

[Bob Clary [:bc] (inactive)]

Thanks! awfy-cmp-osx.corp.mtv2.mozilla.com needed the change. The others were ok.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

From an higher prospective, it's another sign that we should use some python lib to do all the requests (like `requests`). The first sign was that when treeherder switched to gzip compression of HTTP requests, we had to *manually* implement gzip decompression in order to work: see fetch_json in https://github.com/mozilla/arewefastyet/blob/master/slave/utils.py#L203

Using a request lib would make this transparent and avoid us bad surprises in the future (say, if/when treeherder starts using brotli compression or redirects too).

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Bob Clary [:bc:] from comment #3)
> Thanks! awfy-cmp-osx.corp.mtv2.mozilla.com needed the change. The others
> were ok.

Wow, that was fast, thank you!

Comment 6

[Bob Clary [:bc] (inactive)]

Looks like awfy-cmp-osx.corp.mtv2.mozilla.com had been rebooted. I restarted the task.

Comment 7

[Bob Clary [:bc] (inactive)]

The dashboard is showing orange tasks which contain output again. We can call this fixed.