1388892 - Hide nsIntRect implementation details from TableArea

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

TableArea was created in bug 1159990.  In the context of bug 1386277, we want to hide the implementation details of nsIntRect from TableArea.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1388892: TableArea doesn't really need to own the rectangle, except for the union call. Especially since we're exposing the addresses of the members.

Review commit: https://reviewboard.mozilla.org/r/166828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166828/

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8895847 [details]
Bug 1388892:  TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.

https://reviewboard.mozilla.org/r/166828/#review172420

::: layout/tables/TableArea.h:42
(Diff revision 1)
> -    { mRect.UnionRect(aArea1.mRect, aArea2.mRect); }
> +    {
> +      nsIntRect rect(aArea1.mStartCol, aArea1.mStartRow,
> +                     aArea1.mColCount, aArea1.mRowCount);
> +      rect.UnionRect(rect, nsIntRect(aArea2.mStartCol, aArea2.mStartRow,
> +                                     aArea2.mColCount, aArea2.mRowCount));
> +      mStartCol = rect.X();

I'll probably add BaseRect::GetRect(T*, T*, T*, T*) method that can set all four of these values in a single call.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8895847 [details]
Bug 1388892:  TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.

https://reviewboard.mozilla.org/r/166828/#review172528

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8895847 [details]
Bug 1388892:  TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166828/diff/1-2/

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Moved some of the r+'d patches from bug 1389152 to this one as it's using the new method.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8895847 [details]
Bug 1388892:  TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.

https://reviewboard.mozilla.org/r/166828/#review180140

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8895847 [details]
Bug 1388892:  TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.

https://reviewboard.mozilla.org/r/166828/#review180142

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fcd883bac90
TableArea doesn't really need to own the rectangle, except for the union call.  Especially since we're exposing the addresses of the members.  r=xidorn

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7fcd883bac90