Closed Bug 1388921 Opened 7 years ago Closed 7 years ago

OMTP is extra crashy

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Version:
55 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file)

Resume IPC Messages after we send sync textures
7.98 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
When browsing with OMTP enabled, I get some crashes every couple of minutes. Can't get a stack trace for some reason though :/.
We'd allow IPC messages from the main thread to the compositor thread to resume once all async paints finished. However, this was incorrect. We don't actually want to send the compositor the transaction message until we finished syncing the textures on the client side. This patch move the logic to resume IPC transactions to when we sync all hte textures.
Attachment #8896048 - Flags: review?(matt.woodrow)
Attachment #8896048 - Flags: review?(matt.woodrow) → review+
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de88dfb2206a
Resume IPC Messages after we send sync textures. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/de88dfb2206a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Depends on: 1427089
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: