Closed Bug 1388927 Opened 2 years ago Closed 2 years ago

Port bug 1380617 to C-C [Make nsStandardURL.host/spec/etc return punycode by default]

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: jorgk)

References

Details

Attachments

(2 files, 1 obsolete file)

No description provided.
With this patch I can build to the end.
Attachment #8895601 - Flags: review?(jorgk)
Maybe something additional is needed that I don't see now.
Comment on attachment 8895601 [details] [diff] [review]
displayPrePath.patch

Every time M-C make changes in nsIURI.idl, we either need to implement new methods or remove obsolete ones (or both in the same bug).

In this case, |readonly attribute AUTF8String displayPrePath;| was added:
https://hg.mozilla.org/mozilla-central/rev/82c04a5c89b6#l6.18

and for their URIs, they added the methods, for example here:
https://hg.mozilla.org/mozilla-central/rev/82c04a5c89b6#l7.12

So we need to add that to our for URLs LDAP, address book, mailnews URL and mailto URL as the patch has done correctly.

Whether any tests need to change, I can't tell in advance. So we need to land this now and see what happens.
Attachment #8895601 - Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4c712bcd9062
Port bug 1380617 to C-C. Add GetDisplayPrePath() method. r=jorgk
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
We might need to revisit this if there are test failures which I doubt since we don't have tests for URLs, like:
https://hg.mozilla.org/mozilla-central/rev/f1a66e455c36#l1.13
https://hg.mozilla.org/mozilla-central/rev/f1a66e455c36#l2.14
But then, I've been wrong before ;-)
Target Milestone: --- → Thunderbird 57.0
OK, we did get a test failure, I'll take care of it:

TEST-UNEXPECTED-FAIL | ldap/xpcom/tests/unit/test_nsLDAPURL.js | run_test - [run_test : 93] "ldap://xn--wgv71a309e.jp/dc=tes%E6%97%A5t??one?(oc=xyz)" == "ldap://日本誓.jp/dc=tes%E6%97%A5t??one?(oc=xyz)"
Attached patch 1388927-tests.patch (obsolete) — Splinter Review
OK, this fixes and enhances the tests.

Since the originally tested URLs with Japanese characters, ldap://日本誓.jp/, I didn't just want to dumb that down to punycode and instead added some "display" tests.
Assignee: nobody → jorgk
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I've decided to just fix the test and move any further changes to a new bug.
Attachment #8895840 - Attachment is obsolete: true
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/430f8faf075d
Port bug 1380617 to C-C: Fix test expectation. rs=bustage-fix
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Blocks: 1389173
You need to log in before you can comment on or make changes to this bug.