1388927 - Port bug 1380617 to C-C [Make nsStandardURL.host/spec/etc return punycode by default]

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: displayPrePath.patch

With this patch I can build to the end.

Comment 2

[Richard Marti (:Paenglab)]

Maybe something additional is needed that I don't see now.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8895601 [details] [diff] [review]
displayPrePath.patch

Every time M-C make changes in nsIURI.idl, we either need to implement new methods or remove obsolete ones (or both in the same bug).

In this case, |readonly attribute AUTF8String displayPrePath;| was added:
https://hg.mozilla.org/mozilla-central/rev/82c04a5c89b6#l6.18

and for their URIs, they added the methods, for example here:
https://hg.mozilla.org/mozilla-central/rev/82c04a5c89b6#l7.12

So we need to add that to our for URLs LDAP, address book, mailnews URL and mailto URL as the patch has done correctly.

Whether any tests need to change, I can't tell in advance. So we need to land this now and see what happens.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c712bcd9062
Port bug 1380617 to C-C. Add GetDisplayPrePath() method. r=jorgk

Comment 5

[Jorg K (CEST = GMT+2)]

We might need to revisit this if there are test failures which I doubt since we don't have tests for URLs, like:
https://hg.mozilla.org/mozilla-central/rev/f1a66e455c36#l1.13
https://hg.mozilla.org/mozilla-central/rev/f1a66e455c36#l2.14
But then, I've been wrong before ;-)

Comment 6

[Jorg K (CEST = GMT+2)]

OK, we did get a test failure, I'll take care of it:

TEST-UNEXPECTED-FAIL | ldap/xpcom/tests/unit/test_nsLDAPURL.js | run_test - [run_test : 93] "ldap://xn--wgv71a309e.jp/dc=tes%E6%97%A5t??one?(oc=xyz)" == "ldap://日本誓.jp/dc=tes%E6%97%A5t??one?(oc=xyz)"

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1388927-tests.patch

OK, this fixes and enhances the tests.

Since the originally tested URLs with Japanese characters, ldap://日本誓.jp/, I didn't just want to dumb that down to punycode and instead added some "display" tests.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1388927-tests.patch (v2)

I've decided to just fix the test and move any further changes to a new bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/430f8faf075d
Port bug 1380617 to C-C: Fix test expectation. rs=bustage-fix