1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Chris Peterson [:cpeterson]]

clang doesn't support gcc warning options -Wdiscarded-qualifiers or -Wmaybe-uninitialized in media/ffvpx/ffvpxcommon.mozbuild (added in bug 1369791):

warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]

warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx.

clang doesn't support gcc warning options -Wdiscarded-qualifiers or -Wmaybe-uninitialized in media/ffvpxcommon.mozbuild (added in bug 1369791), so only suppress those warnings for real gcc.

warning: unknown warning option '-Wno-discarded-qualifiers'; did you mean '-Wno-ignored-qualifiers'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean '-Wno-uninitialized'? [-Wunknown-warning-option]

Review commit: https://reviewboard.mozilla.org/r/166936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166936/

Comment 2

[Ralph Giles (:rillian)]

Comment on attachment 8895664 [details]
Bug 1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx.

https://reviewboard.mozilla.org/r/166936/#review172374

Thanks for fixing this!

::: commit-message-a4a44:3
(Diff revision 1)
> +Bug 1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx. r?rillian
> +
> +clang doesn't support gcc warning options -Wdiscarded-qualifiers or -Wmaybe-uninitialized in media/ffvpxcommon.mozbuild (added in bug 1369791), so only suppress those warnings for real gcc.

s/suppress/enable/

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: Bug 1388978 - Suppress some more clang warnings in media/ffvpx.

Since I am already poking around in ffvpxcommon.mozbuild's CFLAGS, also suppress these clang -Wvisibility and -Wstring-conversion warnings:

media/ffvpx/libavutil/dummy_funcs.c:83:34 [-Wvisibility] declaration of 'struct AVBufferRef' will not be visible outside of this function
media/ffvpx/libavutil/dummy_funcs.c:83:67 [-Wvisibility] declaration of 'struct AVFrame' will not be visible outside of this function
media/ffvpx/libavutil/utils.c:119:26 [-Wstring-conversion] implicit conversion turns string literal into bool: 'char [19]' to '_Bool'

And remove -Wno-logical-op-parentheses because clang does not currently report any -Wlogical-op-parentheses warnings for ffvpx.

Review commit: https://reviewboard.mozilla.org/r/167182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167182/

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Ralph Giles (:rillian) | needinfo me from comment #2)
> > +clang doesn't support gcc warning options -Wdiscarded-qualifiers or -Wmaybe-uninitialized in media/ffvpxcommon.mozbuild (added in bug 1369791), so only suppress those warnings for real gcc.
> 
> s/suppress/enable/

But we are suppressing, not enabling, those warnings with -Wno-:

>        CFLAGS += [
>            '-Wno-discarded-qualifiers',
>            '-Wno-maybe-uninitialized',
>        ]

Comment 5

[Ralph Giles (:rillian)]

Comment on attachment 8895664 [details]
Bug 1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx.

https://reviewboard.mozilla.org/r/166936/#review172412

::: commit-message-a4a44:3
(Diff revision 1)
> +Bug 1388978 - Fix -Wunknown-warning-option warnings in media/ffvpx. r?rillian
> +
> +clang doesn't support gcc warning options -Wdiscarded-qualifiers or -Wmaybe-uninitialized in media/ffvpxcommon.mozbuild (added in bug 1369791), so only suppress those warnings for real gcc.

Oh, I see what what you mean. Sorry, that's fine.

Comment 6

[Ralph Giles (:rillian)]

Comment on attachment 8895902 [details]
Bug 1388978 - Suppress some more clang warnings in media/ffvpx.

https://reviewboard.mozilla.org/r/167182/#review172416

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49d28f01cd08
Fix -Wunknown-warning-option warnings in media/ffvpx. r=rillian
https://hg.mozilla.org/integration/autoland/rev/e7d4860a4ef2
Suppress some more clang warnings in media/ffvpx. r=rillian

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/49d28f01cd08
https://hg.mozilla.org/mozilla-central/rev/e7d4860a4ef2