1388983 - Close (x) button on shield notification bar too light to see

Status: RESOLVED FIXED

(Shield :: Heartbeat, defect)

Description

[Jet Villegas (inactive)]

Attachment: Screen Shot 2017-08-10 at 2.07.32 PM.png

The white [X] button is difficult to see on the light gray background in the marketing messages in Firefox. See attached screenshot.

Comment 1

[Jet Villegas (inactive)]

Expected results: "Close" is arguably the most important UI for web advertisements, even if it's Firefox doing the advertising. It should be just as visible as the "Make a match" or "Give feedback" buttons

Comment 2

[Matthew N. [:MattN]]

This notification bar is part of SHIELD: https://wiki.mozilla.org/Firefox/Shield/Heartbeat

Comment 3

[Osmose [:osmose, :mkelly]]

jet: Are you still seeing the white X as shown in the screenshot? On Nightly I'm now seeing a small black X:

https://user-images.githubusercontent.com/193106/30085461-661003a6-924b-11e7-91f8-5799a582aeba.png

The smallness and mis-aligned-ness is still an issue, and we have a PR to fix that that should land in mozilla-central before 57 moves out of Nightly: https://github.com/mozilla/normandy/pull/1037

Comment 4

[Jet Villegas (inactive)]

I haven't seen a heartbeat message in a while, but the black X in your screenshot is an improvement. Thanks for fixing this, and the alignment bug.

Comment 5

[Osmose [:osmose, :mkelly]]

Oh yeah, probably should have included how to test this in my comment. :P

In case you still want to verify, https://normandy-mock.dev.mozaws.net/ has instructions on how to set up and run a test case for Shield; any of the "ShowHeartbeat" test cases on that page should work.

I think we can mark this as resolved either way.

Comment 6

[Osmose [:osmose, :mkelly]]

Gijs reports this as still being broken on 56.0 release candidate builds. 

This isn't an issue for 57, as per comment 3.

Matt: We can fix this for 56, but it'd probably require a system add-on update and (short) QA cycle. Thoughts?

Comment 7

[Michael Cooper [:mythmon]]

57 is long gone. Re-closing this.