The gray line between toolbar and preferences page should be removed to match Photon visual spec.

RESOLVED INVALID

Status

()

Firefox
Toolbars and Customization
RESOLVED INVALID
10 months ago
10 months ago

People

(Reporter: evanxd, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Created attachment 8895668 [details]
gray-line.png

According to Photon visual spec[1], the gray line between toolbar and preferences page should be removed. See the gray line in the attachment.

[1]: https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/239960770
(Reporter)

Updated

10 months ago
Flags: qe-verify+
QA Contact: hani.yacoub

Updated

10 months ago
Whiteboard: [photon-preference][triage] → [photon-preference]
(Assignee)

Updated

10 months ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Comment 1

10 months ago
Customized UI is taking the same effect which removes the toolbar's bottom border by adding a "customizing" attribute [1] on the browser root element when entering customized UI and setting a CSS rule [2] for removing the border style.

We can achieve the same thing by using the same mechanism like Customized Page, but it doesn't work for about:preferences. Unlike customized page, preferences panel is loaded by a tabbrowser element (an iframe-like element) and it is unable to touch outside of its scope to add a "preferences" attribute on the browser root element.

Jared, do you have any idea how to add a "preferences" attribute on the browser element when user enters about:preferences?

[1] http://searchfox.org/mozilla-central/source/browser/components/customizableui/CustomizeMode.jsm#502
[2] http://searchfox.org/mozilla-central/source/browser/themes/osx/browser.css#67
Flags: needinfo?(jaws)
I strongly believe that we should not do this.

The Preferences UI is supposed to feel the same as a regular webpage. A similar idea was proposed and implemented for the Add-Ons Manager for a while and then removed later during Australis.

Both the preferences UI and the add-ons manager should continue to have this separator for multiple reasons:
1. These pages are not a special "mode" of the browser like Customize is. Customize mode allows for toolbar items to be dragged and moved around, effectively treating the browser chrome as part of the web page. These two pages do not offer this.
2. These pages scroll, and scrolling without that line will appear awkward
3. If you view Customize with a theme enabled, you will see how it is faded in to the page. We would probably need to do something similar here and it wouldn't make as much sense for these two pages.
Flags: needinfo?(jaws)
(Assignee)

Comment 3

10 months ago
Helen,

I think Jared's suggestion really makes sense to me. For technical perspective, this feature is not that easy to implement since it needs to touch the code out of preferences scope and there might be some architecture changes involved.

Do you have any opinion about this?
Flags: needinfo?(hhuang)

Comment 4

10 months ago
I agree with Jared's opinions and realize this implement might cause more issues. I will get the gray line back and updated the spec.
Flags: needinfo?(hhuang)
(Assignee)

Comment 5

10 months ago
Thanks for the reply!

According to comment 4, we've reached a consensus that toolbar gray line will get back so this bug is invalid.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Priority: P1 → --
Resolution: --- → INVALID

Comment 6

10 months ago
remove whiteboard tag due to its INVALID
Whiteboard: [photon-preference]
You need to log in before you can comment on or make changes to this bug.