Closed Bug 1388994 Opened 3 years ago Closed 3 years ago

GetRequestingPrincipal(const OptionalLoadInfoArgs aOptionalLoadInfoArgs): Pass parameter by ref instead of value

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1394137])

Attachments

(1 file)

Coverity says:

CID 1394137 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)pass_by_value: Passing parameter aOptionalLoadInfoArgs of type mozilla::net::OptionalLoadInfoArgs const (size 528 bytes) by value.
Assignee: nobody → sledru
Comment on attachment 8895690 [details]
Bug 1388994 - GetRequestingPrincipal: Pass parameter by ref instead of value

https://reviewboard.mozilla.org/r/166970/#review172138
Attachment #8895690 - Flags: review?(dd.mozilla) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b1b224b2fb5
GetRequestingPrincipal: Pass parameter by ref instead of value r=dragana
https://hg.mozilla.org/mozilla-central/rev/0b1b224b2fb5
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.