Closed
Bug 1388994
Opened 7 years ago
Closed 7 years ago
GetRequestingPrincipal(const OptionalLoadInfoArgs aOptionalLoadInfoArgs): Pass parameter by ref instead of value
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1394137])
Attachments
(1 file)
Coverity says: CID 1394137 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)pass_by_value: Passing parameter aOptionalLoadInfoArgs of type mozilla::net::OptionalLoadInfoArgs const (size 528 bytes) by value.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sledru
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895690 [details] Bug 1388994 - GetRequestingPrincipal: Pass parameter by ref instead of value https://reviewboard.mozilla.org/r/166970/#review172138
Attachment #8895690 -
Flags: review?(dd.mozilla) → review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b1b224b2fb5 GetRequestingPrincipal: Pass parameter by ref instead of value r=dragana
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b1b224b2fb5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•