1389027 - Support nsDisplayPerspective in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

I have a patch. But rendering result is wrong when the item has offset. I'm still debugging it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Does it work properly in Servo? There could still be bugs on the WebRender side.

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Sure, I'll check how Servo display perspective displayitem.

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Looks like basic perspective support is ok. I use this website (https://www.w3schools.com/cssref/tryit.asp?filename=trycss3_perspective1) for testing. The result is correct. I'll continue implement in layers-free mode.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

(In reply to Morris Tseng [:mtseng] [:Morris] from comment #3)
> Looks like basic perspective support is ok.
I mean the basic support "in servo" is ok

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1389027 - Support nsDisplayPerspective in layers-free mode.

Review commit: https://reviewboard.mozilla.org/r/167412/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167412/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8896127 [details]
Bug 1389027 - Support nsDisplayPerspective in layers-free mode.

https://reviewboard.mozilla.org/r/167412/#review172722

::: layout/painting/nsDisplayList.cpp:8467
(Diff revision 1)
> +  Point3D newOrigin =
> +    Point3D(NSAppUnitsToFloatPixels(transform->ToReferenceFrame().x, appUnitsPerPixel),
> +            NSAppUnitsToFloatPixels(transform->ToReferenceFrame().y, appUnitsPerPixel),
> +            0.0f);
> +  Point3D roundedOrigin(NS_round(newOrigin.x),
> +                        NS_round(newOrigin.y),
> +                        0);
> +

Honestly I have no idea about the correctness of this code. It seems reasonable enough. The rest of the patch looks fine, so if this is producing correct behaviour it's fine by me. Hopefully once we have reftests going we can iron out any problems in this code.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6c148311b9ea677917dfa3d9ecf6f5d2ccfdaa7

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb6874a7489
Support nsDisplayPerspective in layers-free mode. r=kats

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3cb6874a7489