Support nsDisplayPerspective in layers-free mode

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: mtseng, Assigned: mtseng)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

I have a patch. But rendering result is wrong when the item has offset. I'm still debugging it.
Does it work properly in Servo? There could still be bugs on the WebRender side.
Sure, I'll check how Servo display perspective displayitem.
Looks like basic perspective support is ok. I use this website (https://www.w3schools.com/cssref/tryit.asp?filename=trycss3_perspective1) for testing. The result is correct. I'll continue implement in layers-free mode.
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #3)
> Looks like basic perspective support is ok.
I mean the basic support "in servo" is ok
Comment hidden (mozreview-request)
Assignee: nobody → mtseng

Comment 6

10 months ago
mozreview-review
Comment on attachment 8896127 [details]
Bug 1389027 - Support nsDisplayPerspective in layers-free mode.

https://reviewboard.mozilla.org/r/167412/#review172722

::: layout/painting/nsDisplayList.cpp:8467
(Diff revision 1)
> +  Point3D newOrigin =
> +    Point3D(NSAppUnitsToFloatPixels(transform->ToReferenceFrame().x, appUnitsPerPixel),
> +            NSAppUnitsToFloatPixels(transform->ToReferenceFrame().y, appUnitsPerPixel),
> +            0.0f);
> +  Point3D roundedOrigin(NS_round(newOrigin.x),
> +                        NS_round(newOrigin.y),
> +                        0);
> +

Honestly I have no idea about the correctness of this code. It seems reasonable enough. The rest of the patch looks fine, so if this is producing correct behaviour it's fine by me. Hopefully once we have reftests going we can iron out any problems in this code.
Attachment #8896127 - Flags: review?(bugmail) → review+

Comment 8

9 months ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cb6874a7489
Support nsDisplayPerspective in layers-free mode. r=kats

Comment 9

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3cb6874a7489
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.