Closed Bug 1389041 Opened 4 years ago Closed 4 years ago

A simple optimization to test_value_computation.html

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

It seems that bug 1370508 makes the runtime of test_value_computation.html significantly longer, and thus pushes some tasks into perma-timeout.

I just found a simple optimization which should make this test much faster, so that we can have some margin there...

It is still worth investigating why we are slow on that test, though.
Assignee: nobody → xidorn+moz
In my local run with debug build, this cut the runtime by half.
Blocks: 1379267
Comment on attachment 8895774 [details]
Bug 1389041 - Move the iframes out from display tree in test_value_computation.html.

https://reviewboard.mozilla.org/r/167102/#review172560

Nice. :-)
Attachment #8895774 - Flags: review?(cam) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01b5b211063c
Move the iframes out from display tree in test_value_computation.html. r=heycam
https://hg.mozilla.org/mozilla-central/rev/01b5b211063c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.