1389041 - A simple optimization to test_value_computation.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

It seems that bug 1370508 makes the runtime of test_value_computation.html significantly longer, and thus pushes some tasks into perma-timeout.

I just found a simple optimization which should make this test much faster, so that we can have some margin there...

It is still worth investigating why we are slow on that test, though.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1389041 - Move the iframes out from display tree in test_value_computation.html.

We filp the display value of display tree after each property, which
means if we put the iframes there, we are rebuilding style for the
two subdocuments repeatedly. This doesn't really make sense. We are
flipping display tree for restoring #elementf, not for the iframes.

Review commit: https://reviewboard.mozilla.org/r/167102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167102/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

In my local run with debug build, this cut the runtime by half.

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8895774 [details]
Bug 1389041 - Move the iframes out from display tree in test_value_computation.html.

https://reviewboard.mozilla.org/r/167102/#review172560

Nice. :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01b5b211063c
Move the iframes out from display tree in test_value_computation.html. r=heycam

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/01b5b211063c