1389046 - Add information FIREFOX_DEVEDITION about devedition in Product Details

Status: RESOLVED FIXED

(www.mozilla.org :: Product Details, enhancement)

Description

[Rémy Hubscher (:natim)]

Today https://product-details.mozilla.org/1.0/firefox_versions.json

Contains the following:

> {
>     "FIREFOX_NIGHTLY": "57.0a1",
>     "FIREFOX_AURORA": "54.0a2",
>     "FIREFOX_ESR": "52.3.0esr",
>     "FIREFOX_ESR_NEXT": "",
>     "LATEST_FIREFOX_DEVEL_VERSION": "56.0b1",
>     "LATEST_FIREFOX_OLDER_VERSION": "3.6.28",
>     "LATEST_FIREFOX_RELEASED_DEVEL_VERSION": "56.0b1",
>     "LATEST_FIREFOX_VERSION": "55.0"
> }

It give the last version of Firefox releases:

Nightly : FIREFOX_NIGHTLY
Aurora  : FIREFOX_AURORA
Beta    : LATEST_FIREFOX_DEVEL_VERSION
Release : LATEST_FIREFOX_VERSION
ESR     : FIREFOX_ESR

But it doesn't contains the Firefox Dev Edition.

Yesterday, Dev Edition is 55.0b14 while Beta was released as 55.0rc1
Today Dev Edition matches Beta version number.

Comment 1

[Paul [:pmac] McLanahan]

My understanding was that Beta and Dev Edition would always match now that Aurora is gone. Sylvestre could hopefully clear this up for us though (added NI for him).

Comment 2

[Sylvestre Ledru [:Sylvestre]]

We can have cases where we didn't push devedition or we didn't push beta.

Like, if we have a blocking bug on devedition, we would still push beta only until we fixed the devedition bug.

Comment 3

[Paul [:pmac] McLanahan]

We can't currently handle that on the site then since all of the info we have is about beta. So it's possible that we could have broken links to dev edition if beta ships but deved doesn't. Should we add a key specific to dev edition to product-details?

Comment 4

[Rémy Hubscher (:natim)]

> Should we add a key specific to dev edition to product-details?

Yes that what I would expect.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

I will take care of it on the ship-it & product details sides

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: PR

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Done:
$ curl -s https://product-details.mozilla.org/1.0/firefox_versions.json|grep  FIREFOX_DEVEDITION 
  "FIREFOX_DEVEDITION": "56.0b6",

Comment 8

[Paul [:pmac] McLanahan]

Just an FYI: I'm updating our scripts to work with the new "FIREFOX_DEVEDITION" key (thanks Sylvestre!), but it seems that the "FIREFOX_AURORA" value is now empty. This is causing our update scripts to see the data as invalid. I'm fixing them now, but this does mean that product-details will not update on www.mozilla.org until it's fixed. I hope to get it fixed in prod by tomorrow at the latest. Just depends how long code review and testing takes.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

ok, sorry about the empty aurora :( 
I think we can wait until tomorrow.

Comment 10

[Paul [:pmac] McLanahan]

Great. I may have it done today, but I'm glad it's not a rush so we don't have to revert anything. I'm working on the bedrock PR now. I've already fixed our data-updater[0].

Thanks again!

[0] https://ci.us-west.moz.works/blue/organizations/jenkins/product-details-json-watch/activity/

Comment 11

[Paul [:pmac] McLanahan]

Everything is fixed and updates are working.