1389056 - sparc64 issue while building security/nss/lib/freebl because of not setting NSS_USE_64

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170803103124

Steps to reproduce:

gmake[1]: Entering directory '/scratch/firefox/obj-sparc64-sun-solaris2.12/security/nss/lib/freebl/freebl_freebl3'
/usr/bin/gcc -std=gnu99 -o drbg.o -c  -DNDEBUG -DTRIMMED=1 '-DSHLIB_SUFFIX="so"' '-DSHLIB_PREFIX="lib"' '-DSHLIB_VERSION="3"' '-DSOFTOKEN_SHLIB_VERSION="3"' -DRIJNDAEL_INCLUDE_TABLES -DMP_API_COMPATIBLE -DSEED_ONLY_DEV_URANDOM -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_LIBPKIX -I/scratch/firefox/security/nss/lib/freebl -I/scratch/firefox/obj-sparc64-sun-solaris2.12/security/nss/lib/freebl/freebl_freebl3 -I/scratch/firefox/security/nss/lib/freebl/mpi -I/scratch/firefox/security/nss/lib/freebl/ecl -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nspr -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/private/nss -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nss -I/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include    -fPIC  -include /scratch/firefox/obj-sparc64-sun-solaris2.12/mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/drbg.o.pp  -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -fno-strict-aliasing -fno-math-errno -pthread -pipe  -g -O -fno-omit-frame-pointer    /scratch/firefox/security/nss/lib/freebl/drbg.c
In file included from /scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nspr/prerror.h:9:0,
                 from /scratch/firefox/security/nss/lib/freebl/drbg.c:9:
/scratch/firefox/security/nss/lib/freebl/drbg.c: In function 'RNG_RandomUpdate':
/scratch/firefox/obj-sparc64-sun-solaris2.12/dist/include/nspr/prtypes.h:593:38: error: size of array 'arg' is negative
     extern void pr_static_assert(int arg[(condition) ? 1 : -1])
                                      ^
/scratch/firefox/security/nss/lib/freebl/drbg.c:541:5: note: in expansion of macro 'PR_STATIC_ASSERT'
     PR_STATIC_ASSERT(sizeof(size_t) <= 4);
     ^
gmake[1]: *** [/scratch/firefox/config/rules.mk:792: drbg.o] Error 1
gmake[1]: Leaving directory '/scratch/firefox/obj-sparc64-sun-solaris2.12/security/nss/lib/freebl/freebl_freebl3'


Actual results:

The issue here is that NSS_USE_64 was not set.

Comment 1

[Petr Sumbera]

Attachment: Bug1389056.patch

Comment 2

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8895803 [details] [diff] [review]
Bug1389056.patch

Review of attachment 8895803 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, if this fixes the issue I'm happy land this.

Comment 3

[Franziskus Kiefer [:franziskus]]

https://hg.mozilla.org/projects/nss/rev/d83f2573b84eccb40a6e517340b488e7d2ad538b

Comment 4

[Michael Shigorin]

Thank you for the hint, was the same for e2k (bug 1663346).