1389057 - Console log on startup: "While creating services from category 'profile-after-change', service for entry 'Notification Telemetry Service', contract ID '@mozilla.org/notificationTelemetryService;1' does not implement nsIObserver."

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect, P2)

Description

[Mark Banner (:standard8)]

This seems to be harmless, but it is beign logged on every startup:

While creating services from category 'profile-after-change', service for entry 'Notification Telemetry Service', contract ID '@mozilla.org/notificationTelemetryService;1' does not implement nsIObserver.

Bug 1351034 swapped NotificationTelemetryService from a nsIObserver to nsISupports.

Comment 1

[Andrew Overholt [:overholt]]

Maybe Swapnesh can take a look?

Comment 2

[Swapnesh Kumar Sahoo [:swapneshks]]

Actually, I'm a bit busy over the weekend (for convocation). I'll have a look at this bug (this coming Tuesday [15th Aug]) once that's done. I'm totally fine if someone else wants to have a look at this by then.

(Keeping the needinfo flag so that I don't forget about this :) )

Comment 3

[Swapnesh Kumar Sahoo [:swapneshks]]

Attachment: Bug 1389057 - Inherit NotificationTelemetryService from nsIObserver

Review commit: https://reviewboard.mozilla.org/r/168804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168804/

Comment 4

[Swapnesh Kumar Sahoo [:swapneshks]]

Comment on attachment 8897542 [details]
Bug 1389057 - Inherit NotificationTelemetryService from nsIObserver

Hi Andrew,
This patch clears the error message. Who would be the appropriate person to tag for review?

Comment 5

[Swapnesh Kumar Sahoo [:swapneshks]]

(In reply to Swapnesh Kumar Sahoo [:swapneshks] from comment #4)

> This patch clears the error message. Who would be the appropriate person to tag for review?

Sorry, I meant the warn message mentioned in bug description.

Comment 6

[Swapnesh Kumar Sahoo [:swapneshks]]

Just out of curiosity, :smaug mentioned in bug 1211974 that "we explicitly handle the case when nsIObserver isn't implemented" -- https://searchfox.org/mozilla-central/source/xpcom/components/nsCategoryManager.cpp#813

Comment 7

[Andrew Overholt [:overholt]]

Comment on attachment 8897542 [details]
Bug 1389057 - Inherit NotificationTelemetryService from nsIObserver

Maybe Kit?

Comment 8

[Andrew Overholt [:overholt]]

Thanks, Swapnesh!

Comment 9

[Lina Butler [:lina]]

Comment on attachment 8897542 [details]
Bug 1389057 - Inherit NotificationTelemetryService from nsIObserver

https://reviewboard.mozilla.org/r/168804/#review174188

Thanks!

Comment 10

[Swapnesh Kumar Sahoo [:swapneshks]]

My pleasure!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3423703d694a
Inherit NotificationTelemetryService from nsIObserver r=kitcambridge

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3423703d694a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Does seem worth backporting, but feel free to set the status to affected and nominate for approval if you feel otherwise.