1389141 - Fix trailing newlines for a few files in /services

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Daniel Holbert [:dholbert]]

While investigating bug 1388830 (and adding a few lines of debugging code to a JS file), I discovered that the file in question was missing the standard final-newline.  (My editor actually added it for me, without me asking, which cluttered up the temporary local patch that I generated of my tweaks.)

So: I'm filing this bug to add the missing final-newline to this file & a few others that I ran across in /services.  In one case, a file ended with two newlines which I'll collapse to 1.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices

Comment 1

[Daniel Holbert [:dholbert]]

Drat, the initial two files I was looking at were:
 kinto-offline-client.js
 kinto-http-client.js
and now I'm seeing they have these comments:

> /*
>  * This file is generated from kinto.js - do not modify directly.
>  */
[...]
> /*
>  * This file is generated from kinto-http.js - do not modify directly.
>  */

So I guess to get those fixed, we'd want to modify the JS code-generating files, or something. I'll disregard those for now, anyway.

I'll post the rest of my patch, which fixes up 2 other (non-generated) files.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 3

[Daniel Holbert [:dholbert]]

Note that bugzilla's diff viewer isn't super helpful on patches like these -- you may want to just look at the raw text of the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/452fb8cfabbd
Clean up trailing newline for 2 files in "services" directory. r=markh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/452fb8cfabbd