Fix trailing newlines for a few files in /services

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

unspecified
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

While investigating bug 1388830 (and adding a few lines of debugging code to a JS file), I discovered that the file in question was missing the standard final-newline.  (My editor actually added it for me, without me asking, which cluttered up the temporary local patch that I generated of my tweaks.)

So: I'm filing this bug to add the missing final-newline to this file & a few others that I ran across in /services.  In one case, a file ended with two newlines which I'll collapse to 1.

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices
Drat, the initial two files I was looking at were:
 kinto-offline-client.js
 kinto-http-client.js
and now I'm seeing they have these comments:

> /*
>  * This file is generated from kinto.js - do not modify directly.
>  */
[...]
> /*
>  * This file is generated from kinto-http.js - do not modify directly.
>  */

So I guess to get those fixed, we'd want to modify the JS code-generating files, or something. I'll disregard those for now, anyway.

I'll post the rest of my patch, which fixes up 2 other (non-generated) files.
Posted patch fix v1Splinter Review
Attachment #8895893 - Flags: review?(markh)
Note that bugzilla's diff viewer isn't super helpful on patches like these -- you may want to just look at the raw text of the patch.
Summary: Add trailing newlines to a few files in /services → Fix trailing newlines for a few files in /services
Attachment #8895893 - Flags: review?(markh) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/452fb8cfabbd
Clean up trailing newline for 2 files in "services" directory. r=markh
https://hg.mozilla.org/mozilla-central/rev/452fb8cfabbd
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.