1389161 - console.table([{ column1: 0, column2: 1 }]) output is wrong

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce: 
1. Open the console
2. Evaluate `console.table([{ column1: 0, column2: 1 }])`

Expected results:

+-------+---------+---------+
| index | column1 | column2 |
+-------+---------+---------+
|     0 |       0 |       1 |
+-------+---------+---------+


Actual results: 

+-------+-------------+---------+
| index |   column1   | column2 |
+-------+-------------+---------+
|     0 |    Object{} |       1 |
+-------+-------------+---------+

i.e. `Object{}` should be `0`

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1389161 - Fix console.table for nested object with falsy values; .

A loose checking was causing 0 and undefined values to be rendered as Object.
We fix this by checking explicitely if the grip has a value property.
A test is added to make sure we handle those cases as expected.

Review commit: https://reviewboard.mozilla.org/r/167532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167532/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8896244 [details]
Bug 1389161 - Fix console.table for nested object with falsy values; .

https://reviewboard.mozilla.org/r/167532/#review172720

Works for me!

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

TRY is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=174eaf360b5ee48e9392cc525254c576a2a3232a , let's push

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a95a9bde76
Fix console.table for nested object with falsy values; r=Honza.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8a95a9bde76

Comment 6

[Md. Rahimul Islam]

I have successfully reproduced this bug with Nightly 57.0a1 (2017-08-10) (32-bit) on windows 10(32bit)

this bug is verified fix with  latest nightly 57.0a1 (2017-08-15) (32-bit)

Build ID: 20170815100349
Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0

Comment 7

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 57.0a1 (2017-08-10) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 57.0a1

Build ID 	20170815100349
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

[Bugday-20170816]