Closed Bug 1389165 Opened 4 years ago Closed 4 years ago

Cleanup before adding the search on the home page in about:telemetry

Categories

(Toolkit :: Telemetry, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub)

References

Details

Attachments

(3 files)

The search doesn't work for the thread hangs section for now.
Blocks: 1385350
Summary: Fix the search for thread hangs in about:telemetry → Cleanup before adding the search on the home page in about:telemetry
Attachment #8895981 - Flags: review?(gfritzsche) → review?(chutten)
Attachment #8896263 - Flags: review?(gfritzsche) → review?(chutten)
Attachment #8896264 - Flags: review?(gfritzsche) → review?(chutten)
Comment on attachment 8896263 [details]
Bug 1389165 - Fix the search for thread hangs in about:telemetry

https://reviewboard.mozilla.org/r/167548/#review173998

lgtm
Attachment #8896263 - Flags: review?(chutten) → review+
Comment on attachment 8895981 [details]
Bug 1389165 - Hide caption when no data for table in about:telemetry

https://reviewboard.mozilla.org/r/167256/#review174002

looks good.
Attachment #8895981 - Flags: review?(chutten) → review+
Comment on attachment 8896264 [details]
Bug 1389165 - Cleanup html markup of about:telemetry

https://reviewboard.mozilla.org/r/167550/#review174006

Is this because we're now taking care of spacing in CSS? If so, heartily r+
Attachment #8896264 - Flags: review?(chutten) → review+
Comment on attachment 8896264 [details]
Bug 1389165 - Cleanup html markup of about:telemetry

https://reviewboard.mozilla.org/r/167550/#review174006

We display for all section their div.data for the search on the home page. I removed the html that was not actual data from this div. :)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3b5f1b11db0e
Fix the search for thread hangs in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/850ff7976b8d
Hide caption when no data for table in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/6e599cdfa3fb
Cleanup html markup of about:telemetry r=chutten
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.