Cleanup before adding the search on the home page in about:telemetry

RESOLVED FIXED in Firefox 57

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: flyingrub, Assigned: flyingrub)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

2 years ago
The search doesn't work for the thread hangs section for now.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Blocks: 1385350
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Summary: Fix the search for thread hangs in about:telemetry → Cleanup before adding the search on the home page in about:telemetry
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Attachment #8895981 - Flags: review?(gfritzsche) → review?(chutten)
Attachment #8896263 - Flags: review?(gfritzsche) → review?(chutten)
Attachment #8896264 - Flags: review?(gfritzsche) → review?(chutten)

Comment 13

2 years ago
mozreview-review
Comment on attachment 8896263 [details]
Bug 1389165 - Fix the search for thread hangs in about:telemetry

https://reviewboard.mozilla.org/r/167548/#review173998

lgtm
Attachment #8896263 - Flags: review?(chutten) → review+

Comment 14

2 years ago
mozreview-review
Comment on attachment 8895981 [details]
Bug 1389165 - Hide caption when no data for table in about:telemetry

https://reviewboard.mozilla.org/r/167256/#review174002

looks good.
Attachment #8895981 - Flags: review?(chutten) → review+

Comment 15

2 years ago
mozreview-review
Comment on attachment 8896264 [details]
Bug 1389165 - Cleanup html markup of about:telemetry

https://reviewboard.mozilla.org/r/167550/#review174006

Is this because we're now taking care of spacing in CSS? If so, heartily r+
Attachment #8896264 - Flags: review?(chutten) → review+
Assignee

Comment 16

2 years ago
mozreview-review-reply
Comment on attachment 8896264 [details]
Bug 1389165 - Cleanup html markup of about:telemetry

https://reviewboard.mozilla.org/r/167550/#review174006

We display for all section their div.data for the search on the home page. I removed the html that was not actual data from this div. :)
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 17

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3b5f1b11db0e
Fix the search for thread hangs in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/850ff7976b8d
Hide caption when no data for table in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/6e599cdfa3fb
Cleanup html markup of about:telemetry r=chutten
Keywords: checkin-needed

Comment 18

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b5f1b11db0e
https://hg.mozilla.org/mozilla-central/rev/850ff7976b8d
https://hg.mozilla.org/mozilla-central/rev/6e599cdfa3fb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.