Implement nsLDAPURL::GetDisplay[Spec|Host|HostPort] better and enhance test

NEW
Unassigned

Status

MailNews Core
LDAP Integration
10 months ago
7 months ago

People

(Reporter: Jorg K (GMT+2) (bustage-fix and urgent reviews only), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

5.35 KB, patch
Jorg K (GMT+2) (bustage-fix and urgent reviews only)
: review?
rkent
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1388927 +++

In bug 1388927 I had to adjust the test expectation
https://hg.mozilla.org/comm-central/rev/430f8faf075db3d4915786d534b811530267fb23#l1.12
since spec, host, hostPort and prePath now return (ASCII) punycode due to bug 1380617.

Since the test contains a URL with Japanese characters we should consider implementing nsLDAPURL::GetDisplay[Spec|Host|HostPort] and restore the test case.
Created attachment 8895934 [details] [diff] [review]
1389173-ldap-url.patch (v1)
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8895934 - Flags: review?(rkent)
Looking at bug 1389762, we might need to do something like this for NNTP as well.
Please ignore the previous comment, bug 1389762 has a different cause.
Assignee: jorgk → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.