Closed Bug 1389195 Opened 2 years ago Closed 2 years ago

Unport bug 1388946 from C-C: Set extensions.legacy.enabled to true for TB

Categories

(Thunderbird :: General, enhancement)

52 Branch
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: jorgk, Assigned: jorgk)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
One review will do.

I noticed that |pref("extensions.logging.enabled", false);| was in the file twice, so I took the second copy out. You can see the first copy in the patch.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8895980 - Flags: review?(mkmelin+mozilla)
Attachment #8895980 - Flags: review?(acelists)
Sorry, I didn't to the SM part since I don't know how you structure/group your preferences.
Flags: needinfo?(frgrahl)
Attachment #8895980 - Flags: review?(mkmelin+mozilla)
Attachment #8895980 - Flags: review?(acelists)
Attachment #8895980 - Flags: review+
Let's make this TB only since SM already dealt with this in bug 1373375 (as FRG told me in a PM):
https://hg.mozilla.org/comm-central/rev/ccbd9c80a4ddd761cc7e7c24c3886cf8412bda35#l1.13

I'm not sure what the other stuff is they landed there. FRG, do we need it and/or the confvars.sh change?
Summary: Unport bug 1388946 from C-C: Set extensions.legacy.enabled to true for TB/IB/SM. → Unport bug 1388946 from C-C: Set extensions.legacy.enabled to true for TB
Oh, I forgot to mention, the thing I'm undoing is this:
https://hg.mozilla.org/integration/autoland/rev/45d8844f0124#l1.12
Thanks Jorg for the heads up. SeaMonkey is covered in bug 1373375 which we spoke or better mailed about a few weeks ago. You might want to take the build time variable too from it. This will probably be the next step if it is not altogether removed. I read yesterday that the pref will become a compile time variable and I think this one will be it if not renamed.

As far as I see it bug 1373375 is for firefox prefs only. Shouldn'r concern the c-c apps right now. The default is still true for them so technically you won't need to change anything right now.

You already have the "pref("extensions.startupScanScopes", 4)". "extensions.legacy.exceptions" is a legacy exception list. Any add-on in it will not be flagged as legacy. You dealt with it with css but this is low level access and for now honored by toolkit. Not sure if you want it. 

All of this might change till Fx 57 GA but I doubt they will be able to remove things like the default theme from the exception list.
Flags: needinfo?(frgrahl)
Thanks, FRG. I moved the new extension further down just after extensions.startupScanScopes. I also added the confvars.sh.
Attachment #8895980 - Attachment is obsolete: true
Attachment #8895988 - Flags: review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/df01b55915fa
Allow legacy extensions in TB. r=mkmelin
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
See Also: → 1418566
You need to log in before you can comment on or make changes to this bug.