1389223 - The dark theme titlebar changes color when in windowed vs maximized when using Windows 7 classic themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[tcapone]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170810100255

Steps to reproduce:

Switched to the dark theme from Customize. Made the window smaller (i.e. not maximized).


Actual results:

While in the Customize tab as well the Tabs on top are blue:
https://i.imgur.com/u8e7Obr.png

But outside of it, it looks fine:
https://i.imgur.com/7BN5uHP.png

In a smaller window, it goes back to the blue color:
https://i.imgur.com/Gs6HXp1.png


Expected results:

It should be dark throughout I think? It may be because I'm on Windows 7 using the classic theme, but I don't know if the color should change from being maximized to a smaller window.

Comment 1

[Johann Hofmann [:johannh]]

This was made consistent by bug 1399498.

Comment 2

[ovidiu boca[:Ovidiu]]

Tested on Windows 7 x32 with FF Nightly 58.0a1(2017-09-21) and here are my results. I don't see any difference on title bar color, with the dark theme enabled, when the browser window is in maximize or in window mode. 

Window in full size - https://imgur.com/a/2Vbb6
Window - not in full size - https://imgur.com/a/HwWkA

Tcapone can you please retest this with the latest Nightly? Thanks

Comment 3

[ovidiu boca[:Ovidiu]]

Based on comment 2 I will mark this as verified fixed. Tcapone please feel free to add a comment if your output is different. Thanks

Comment 4

[tcapone]

(In reply to ovidiu boca[:Ovidiu] from comment #2)
> Tested on Windows 7 x32 with FF Nightly 58.0a1(2017-09-21) and here are my
> results. I don't see any difference on title bar color, with the dark theme
> enabled, when the browser window is in maximize or in window mode. 
> 
> Window in full size - https://imgur.com/a/2Vbb6
> Window - not in full size - https://imgur.com/a/HwWkA
> 
> Tcapone can you please retest this with the latest Nightly? Thanks

Sorry I didn't see the email. But it's "fixed" in the sense it's blue all the time. I thought it looked better when it was dark as in the second screen shot: https://i.imgur.com/7BN5uHP.png however.

Comment 5

[ovidiu boca[:Ovidiu]]

Please see the attached file, this is the expected result for Windows 7 when Windows has Aero theme and Firefox has dark theme enabled. Please check what is your Windows theme, you can do that if you go to "Personalize". 
Thanks

Comment 6

[ovidiu boca[:Ovidiu]]

Attachment: Windows 7 specification for Dark Theme(Aero theme for Windows 7).png

Comment 7

[tcapone]

(In reply to ovidiu boca[:Ovidiu] from comment #6)
> Created attachment 8919649 [details]
> Windows 7 specification for Dark Theme(Aero theme for Windows 7).png

I'm using the Classic theme. If it's supposed to look like that (Title bar is blue, tabs are dark grey/black such as your example: https://i.imgur.com/4p6X8oI.png ) it's fine and fixed. Can I make it look like: https://i.imgur.com/7BN5uHP.png (Title bar matches theme more) with userChrome/userContent?

Comment 8

[ovidiu boca[:Ovidiu]]

To be honest I don't know but maybe Johann can help us here.
Johann, can you please take a look at comment 7? Thanks

Comment 9

[Johann Hofmann [:johannh]]

(In reply to tcapone from comment #7)
> (In reply to ovidiu boca[:Ovidiu] from comment #6)
> > Created attachment 8919649 [details]
> > Windows 7 specification for Dark Theme(Aero theme for Windows 7).png
> 
> I'm using the Classic theme. If it's supposed to look like that (Title bar
> is blue, tabs are dark grey/black such as your example:
> https://i.imgur.com/4p6X8oI.png ) it's fine and fixed. Can I make it look
> like: https://i.imgur.com/7BN5uHP.png (Title bar matches theme more) with
> userChrome/userContent?

Yes, off-hand that should be possible by overriding this rule in compacttheme.css: https://searchfox.org/mozilla-central/rev/1c4da216e00ac95b38a3f236e010b31cdfaae03b/browser/themes/windows/compacttheme.css#120

Bugzilla is really not the right place to discuss that, though. Please ask in a forum like https://www.reddit.com/r/FirefoxCSS/ if you need more help.