Deprecate SimpleTest.requestFlakyTimeout in favor of the mozilla/no-arbitrary-setTimeout eslint rule

NEW
Unassigned

Status

Testing
Mochitest
4 months ago
3 months ago

People

(Reporter: ahal, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 months ago
As discussed in bug 1385352, both requestFlakyTimeout and the eslint rule are accomplishing the same thing. We should have a single mechanism for preventing flaky timeouts.

I vote for the eslint rule because:

1) Doesn't need to be implemented per test harness (and reduces complexity)
2) It's a common tool that many devs are already familiar with
3) Devs can choose to disable it at the directory, file or line level

This bug should:
1) Remove the requestFlakyTimeout mechanism
2) Replace invocations of SimpleTest.requestFlakyTimeout with // eslint-disable
3) Enable mozilla/no-arbitrary-setTimeout on mochitest plain and chrome

Comment 1

4 months ago
I like eslint too, but keep in mind that some mochitests may not be linted, due to exclusions in .eslintignore.
You need to log in before you can comment on or make changes to this bug.