If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Enable -Wparentheses when available

RESOLVED WONTFIX

Status

()

Core
Rewriting and Analysis
P3
normal
RESOLVED WONTFIX
a month ago
a month ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
Introduced in gcc 4.8, warns about some wrong operation priorities
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a month ago
I was playing with some warnings Chris, so, I did it. Hope you don't mind!

Found stuff only in thirdparty code:
media/libcubeb/src/cubeb_pulse.c:755:58: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
gfx/vr/openvr/src/pathtools_public.cpp:658:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

Forwarded the second here: 
https://github.com/ValveSoftware/openvr/pull/607
(Assignee)

Updated

a month ago
Assignee: nobody → sledru
(Assignee)

Comment 3

a month ago
and for Cube: https://github.com/kinetiknz/cubeb/pull/349
We shouldn't need to explicitly enable -Wparentheses warnings because they are implicitly enabled by gcc's -Wall flag:

https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Warning-Options.html
and clang -Wall:

https://github.com/llvm-mirror/clang/blob/1ce5afe7e40266a14a2a0dbd2acbe45f78e60379/include/clang/Basic/DiagnosticGroups.td#L741
(Assignee)

Comment 6

a month ago
silly me. This will be fixed with the upgrade to gcc 6 then
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → WONTFIX
(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> silly me. This will be fixed with the upgrade to gcc 6 then

We're already building with gcc 4.9, so it's effectively already there.
(Assignee)

Comment 8

a month ago
I don't understand why bug 1385537 wasn't detected by the CI
(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> I don't understand why bug 1385537 wasn't detected by the CI

See comment 3 in that bug.
Attachment #8895987 - Flags: review?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.