|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Introduced in gcc 4.8, warns about some wrong operation priorities
I was playing with some warnings Chris, so, I did it. Hope you don't mind! Found stuff only in thirdparty code: media/libcubeb/src/cubeb_pulse.c:755:58: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] gfx/vr/openvr/src/pathtools_public.cpp:658:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses] Forwarded the second here: https://github.com/ValveSoftware/openvr/pull/607
and for Cube: https://github.com/kinetiknz/cubeb/pull/349
We shouldn't need to explicitly enable -Wparentheses warnings because they are implicitly enabled by gcc's -Wall flag: https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Warning-Options.html
silly me. This will be fixed with the upgrade to gcc 6 then
(In reply to Sylvestre Ledru [:sylvestre] from comment #6) > silly me. This will be fixed with the upgrade to gcc 6 then We're already building with gcc 4.9, so it's effectively already there.
I don't understand why bug 1385537 wasn't detected by the CI
(In reply to Sylvestre Ledru [:sylvestre] from comment #8) > I don't understand why bug 1385537 wasn't detected by the CI See comment 3 in that bug.