1389243 - Enable -Wparentheses when available

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, enhancement, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

Introduced in gcc 4.8, warns about some wrong operation priorities

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1389243 - Enable -Wparentheses when available

Review commit: https://reviewboard.mozilla.org/r/167260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167260/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I was playing with some warnings Chris, so, I did it. Hope you don't mind!

Found stuff only in thirdparty code:
media/libcubeb/src/cubeb_pulse.c:755:58: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses]
gfx/vr/openvr/src/pathtools_public.cpp:658:17: warning: suggest parentheses around assignment used as truth value [-Wparentheses]

Forwarded the second here: 
https://github.com/ValveSoftware/openvr/pull/607

Comment 3

[Sylvestre Ledru [:Sylvestre]]

and for Cube: https://github.com/kinetiknz/cubeb/pull/349

Comment 4

[Chris Peterson [:cpeterson]]

We shouldn't need to explicitly enable -Wparentheses warnings because they are implicitly enabled by gcc's -Wall flag:

https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Warning-Options.html

Comment 5

[Chris Peterson [:cpeterson]]

and clang -Wall:

https://github.com/llvm-mirror/clang/blob/1ce5afe7e40266a14a2a0dbd2acbe45f78e60379/include/clang/Basic/DiagnosticGroups.td#L741

Comment 6

[Sylvestre Ledru [:Sylvestre]]

silly me. This will be fixed with the upgrade to gcc 6 then

Comment 7

[Mike Hommey [:glandium]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> silly me. This will be fixed with the upgrade to gcc 6 then

We're already building with gcc 4.9, so it's effectively already there.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

I don't understand why bug 1385537 wasn't detected by the CI

Comment 9

[Mike Hommey [:glandium]]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> I don't understand why bug 1385537 wasn't detected by the CI

See comment 3 in that bug.