Closed Bug 1389255 Opened 6 years ago Closed 6 years ago

Fix the styling of multitable section in about:telemetry

Categories

(Toolkit :: Telemetry, defect, P1)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub)

References

Details

Attachments

(1 file)

Bug 1389255 - Fix the styling of multitable section in about:telemetry
59 bytes, text/x-review-board-request
chutten
: review+
Details 
The headings in multi-table sections are oddly-sized (e.g. environment -> addons). The "activeAddons" heading is smaller than the following table heading / addon name. It is hard to separate from the rest of the sections as there is not enough space to the preceding element.
Attachment #8895999 - Flags: review?(gfritzsche) → review?(chutten)
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry

https://reviewboard.mozilla.org/r/167272/#review173610

::: toolkit/content/aboutTelemetry.css:300
(Diff revision 2)
>  caption {
>    font-weight: bold;
>    white-space: nowrap;
>    text-align: left;
> -  font-size: large;
> +  font-size: 24px;
> +  margin: 24px 0 12px 0;

Can we get any of these values out of Common.css? Or peg them to the current font size?
Attachment #8895999 - Flags: review?(chutten)
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry

https://reviewboard.mozilla.org/r/167272/#review173996

::: toolkit/content/aboutTelemetry.css:300
(Diff revision 2)
>  caption {
>    font-weight: bold;
>    white-space: nowrap;
>    text-align: left;
> -  font-size: large;
> +  font-size: 24px;
> +  margin: 24px 0 12px 0;

I don't think we can get them from common.css.
I cleaned it up a little and use em instead of px now.
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry

https://reviewboard.mozilla.org/r/167272/#review173610

> Can we get any of these values out of Common.css? Or peg them to the current font size?

I switched to em instead of px. Also useless css removed.
Attachment #8895999 - Flags: review?(gfritzsche) → review?(chutten)
Comment on attachment 8895999 [details]
Bug 1389255 - Fix the styling of multitable section in about:telemetry

https://reviewboard.mozilla.org/r/167272/#review174036
Attachment #8895999 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cca3c23a2235
Fix the styling of multitable section in about:telemetry r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cca3c23a2235
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.