1389269 - Clean up standalone PWA UI layout

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

The standalone PWA activity uses the custom tabs layout for some reason, which seems unnecessary. It also has a gap between the top of the GeckoView and the statusbar which is annoying.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1389269 - Clean up the UI layout for standalone webapps

Review commit: https://reviewboard.mozilla.org/r/167280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167280/

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8896007 [details]
Bug 1389269 - Clean up the UI layout for standalone webapps

https://reviewboard.mozilla.org/r/167280/#review172740

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/094e6802c2f4
Clean up the UI layout for standalone webapps r=droeh

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1369817, bug 1369815, bug 1389269 and bug 1126479 for crashing in mochitest-chrome-3's layout/style/test/chrome/test_stylesheet_clone_import_rule.html on debug:

bug 1369817
https://hg.mozilla.org/integration/mozilla-inbound/rev/4af3a98934c427226e095246a098008bc3474ee7
https://hg.mozilla.org/integration/mozilla-inbound/rev/6bd81631bfad32fdc2fa46a8937d189caa21cb3d

bug 1369815
https://hg.mozilla.org/integration/mozilla-inbound/rev/7780a4af90284e7f812d44ec32adb68dcbcc94b1
https://hg.mozilla.org/integration/mozilla-inbound/rev/76f15802d69c2835eaa13e92df4bee34637f3b6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/4871dc084c88feecdbabe1b3a9acdb5ffaa71a2b
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bbb1bd8335d0c49ac477e60e85a03029c8c6a17
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc485e4ba834888fb7f5bbb97f9a91c33c1a485

bug 1389269
https://hg.mozilla.org/integration/mozilla-inbound/rev/78e49684354331b02d3e425d2afcd757559bd7db

bug 1126479
https://hg.mozilla.org/integration/mozilla-inbound/rev/bec2a9eac2d9c7ec52543e5b77a6ee38c3f6879f
https://hg.mozilla.org/integration/mozilla-inbound/rev/337a6416a05bc3a9fac980eaa54084b78cd639b6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4fb119706335b308f049949e5641565b035e4f80&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123274657&repo=mozilla-inbound

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

So Try shows this is indeed from this patchset: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06dc0a37528eddc566bf22c4db30090d2e24922c&selectedJob=123311402

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Additionally, this caused an android lint failure for unused resources: https://treeherder.mozilla.org/logviewer.html#?job_id=123269840&repo=mozilla-inbound

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/270fefa0da6d
Clean up the UI layout for standalone webapps r=droeh

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fd5d156b9bb
Remove unused file r=me DONTBUILD

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/270fefa0da6d
https://hg.mozilla.org/mozilla-central/rev/3fd5d156b9bb