1389411 - stylo: Crash in mozalloc_abort | abort | std::io::stdio::_print | style::properties::longhands::font_family::computed_value::{{impl}}::parse

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Chris Peterson [:cpeterson]]

This bug was filed from the Socorro interface and is 
report bp-bd956033-75cc-4458-9bcc-1f0e20170809.
=============================================================

std::io::stdio::_print is a generic crash signature. About two-thirds of these crash reports in Nightly 57 look like WebRender crash bp-095c3582-a374-48ba-a03a-ec22a0170725 (bug 1387962) but about one-third look like Stylo crash bp-bd956033-75cc-4458-9bcc-1f0e20170809:

Frame 	Module 	Signature 	Source
0 	libmozglue.dylib 	mozalloc_abort(char const*) 	memory/mozalloc/mozalloc_abort.cpp:33
1 	libmozglue.dylib 	abort 	memory/mozalloc/mozalloc_abort.cpp:80
2 	XUL 	std::panicking::rust_panic 	src/libpanic_abort/lib.rs:61
3 	XUL 	std::panicking::rust_panic_with_hook 	src/libstd/panicking.rs:565
4 	XUL 	std::panicking::begin_panic<collections::string::String> 	src/libstd/panicking.rs:511
5 	XUL 	std::panicking::begin_panic_fmt 	src/libstd/panicking.rs:495
6 	XUL 	std::io::stdio::_print 	src/libstd/io/stdio.rs:691
7 	XUL 	style::properties::longhands::font_family::computed_value::{{impl}}::parse 	obj-firefox/toolkit/library/x86_64-apple-darwin/release/build/style-58e9e45a1cbf378c/out/properties.rs:20945
8 	XUL 	style::properties::longhands::font_family::{{impl}}::parse 	obj-firefox/toolkit/library/x86_64-apple-darwin/release/build/style-58e9e45a1cbf378c/out/properties.rs:21098
9 	XUL 	style::properties::LonghandId::parse_value::h6b0081ec7a10fe2a 	
10 	XUL 	style::properties::{{impl}}::parse_into 	obj-firefox/toolkit/library/x86_64-apple-darwin/release/build/style-58e9e45a1cbf378c/out/properties.rs:111870
11 	XUL 	style::properties::declaration_block::parse_property_declaration_list 	servo/components/style/properties/declaration_block.rs:961
12 	XUL 	style::stylesheets::rule_parser::{{impl}}::parse_block 	servo/components/style/stylesheets/rule_parser.rs:529
13 	XUL 	cssparser::rules_and_declarations::parse_qualified_rule<style::stylesheets::rule_parser::TopLevelRuleParser, selectors::parser::SelectorParseError<style_traits::StyleParseError>> 	servo/components/style/stylesheets/rule_parser.rs:290
14 	XUL 	style::stylesheets::stylesheet::{{impl}}::from_str 	third_party/rust/cssparser/src/rules_and_declarations.rs:365
15 	XUL 	geckoservo::glue::Servo_StyleSheet_FromUTF8Bytes 	servo/ports/geckolib/glue.rs:827
16 	XUL 	mozilla::ServoStyleSheet::ParseSheet(mozilla::css::Loader*, nsAString const&, nsIURI*, nsIURI*, nsIPrincipal*, unsigned int, nsCompatibility, mozilla::css::LoaderReusableStyleSheets*) 	layout/style/ServoStyleSheet.cpp:212
17 	XUL 	mozilla::css::Loader::ParseSheet(nsAString const&, mozilla::css::SheetLoadData*, bool&) 	layout/style/Loader.cpp:1785
18 	XUL 	mozilla::css::SheetLoadData::OnStreamComplete(nsIUnicharStreamLoader*, nsISupports*, nsresult, nsAString const&) 	layout/style/Loader.cpp:1009
19 	XUL 	nsUnicharStreamLoader::OnStopRequest(nsIRequest*, nsISupports*, nsresult) 	netwerk/base/nsUnicharStreamLoader.cpp:96
20 	XUL 	mozilla::net::nsHTTPCompressConv::OnStopRequest(nsIRequest*, nsISupports*, nsresult) 	netwerk/streamconv/converters/nsHTTPCompressConv.cpp:169
21 	XUL 	mozilla::net::HttpChannelChild::DoOnStopRequest(nsIRequest*, nsresult, nsISupports*) 	netwerk/protocol/http/HttpChannelChild.cpp:1177
22 	XUL 	mozilla::net::HttpChannelChild::OnStopRequest(nsresult const&, mozilla::net::ResourceTimingStruct const&) 	netwerk/protocol/http/HttpChannelChild.cpp:1080
23 	XUL 	mozilla::net::ChannelEventQueue::FlushQueue() 	netwerk/ipc/ChannelEventQueue.cpp:93
24 	XUL 	mozilla::net::ChannelEventQueue::ResumeInternal()::CompleteResumeRunnable::Run() 	netwerk/ipc/ChannelEventQueue.h:324
25 	XUL 	mozilla::SchedulerGroup::Runnable::Run() 	xpcom/threads/SchedulerGroup.cpp:356
26 	XUL 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1446
27 	XUL 	NS_ProcessPendingEvents(nsIThread*, unsigned int) 	xpcom/threads/nsThreadUtils.cpp:422
28 	XUL 	nsBaseAppShell::NativeEventCallback() 	widget/nsBaseAppShell.cpp:97
29 	XUL 	nsAppShell::ProcessGeckoEvents(void*) 	widget/cocoa/nsAppShell.mm:409

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This was removed long ago in https://github.com/servo/servo/commit/42f055adb655b5575b1f3659928a9d45474a3fe0