Closed Bug 1389416 Opened 3 years ago Closed 3 years ago

UITour's Highlight on Linux doesn't match Photon's style

Categories

(Firefox :: Tours, enhancement, P3)

56 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [photon-onboarding])

Attachments

(5 files, 1 obsolete file)

Attached image Screenshot
See screenshot.
We should match it to the latest spec as well.
Linux has its own style because some people without X compositor aren't able to show transparent color[1], and the style need to be compatible with it.
We may need to make sure if this is still the case and proceed. If it's still the case we need to come out a fallback style.


[1]http://searchfox.org/mozilla-central/source/browser/themes/linux/browser.css#878
Latest spec:
https://bugzilla.mozilla.org/show_bug.cgi?id=1384841

Note the fill color is 30% opacity which hasn't be updated into spec yet.
Flags: qe-verify+
Priority: -- → P3
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Comment on attachment 8896867 [details]
Workaround for Linux

Michael can you take a look on this Linux-specific style?

The reason is for compatibility as I commented above. In a machine without X compositor they'd just see the border without background color.
Attachment #8896867 - Flags: ui-review?(mverdi)
Attached image Linux without X Compositor (obsolete) —
This is the one with X-Compositor turned off.
Attachment #8896880 - Flags: ui-review?(mverdi)
Attachment #8896880 - Attachment is obsolete: true
Attachment #8896880 - Flags: ui-review?(mverdi)
Attachment #8896882 - Flags: ui-review?(mverdi)
Comment on attachment 8896871 [details]
Bug 1389416 - Match UITour's highlight with Photon's style.

https://reviewboard.mozilla.org/r/168160/#review173384

r=me assuming you get ui-review.
Attachment #8896871 - Flags: review?(gijskruitbosch+bugs) → review+
It might be good to have a screenshot of what this looks like on the back button, too.
Comment on attachment 8896882 [details]
Linux without X Compositor

That will work. Will we only show this to those linux users who can't have transparent colors?
Flags: needinfo?(rexboy)
Attachment #8896882 - Flags: ui-review?(mverdi) → ui-review+
(In reply to Verdi [:verdi] from comment #11)
> Comment on attachment 8896882 [details]
> Linux without X Compositor
> 
> That will work. Will we only show this to those linux users who can't have
> transparent colors?

From Firefox's side, it's unable to detect if they have X compositor or not. So for users on Linux who do have transparent color, they'll get transparent color + thick border, like another attachment I set ui-review to you. 
It's a little bit ugly than other OSes but I think we should try to keep the compatibility.
Flags: needinfo?(rexboy)
Assignee: nobody → rexboy
Attached image backbutton highlight
Left: X compositor on
Right: X compositor off
Attachment #8896867 - Flags: ui-review?(mverdi) → ui-review+
try running.
Keywords: checkin-needed
Pushed by kmlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfd8b11bc6c1
Match UITour's highlight with Photon's style. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/cfd8b11bc6c1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified as fixed.
Status: RESOLVED → VERIFIED
I have verified that the UITour's Highlight on Linux matches Photon's style on Ubuntu 16.04 x32 with Firefox 58.
You need to log in before you can comment on or make changes to this bug.