1389416 - UITour's Highlight on Linux doesn't match Photon's style

Status: VERIFIED FIXED

(Firefox :: Tours, enhancement, P3)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Screenshot

See screenshot.
We should match it to the latest spec as well.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Linux has its own style because some people without X compositor aren't able to show transparent color[1], and the style need to be compatible with it.
We may need to make sure if this is still the case and proceed. If it's still the case we need to come out a fallback style.


[1]http://searchfox.org/mozilla-central/source/browser/themes/linux/browser.css#878

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Latest spec:
https://bugzilla.mozilla.org/show_bug.cgi?id=1384841

Note the fill color is 30% opacity which hasn't be updated into spec yet.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Workaround for Linux

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8896867 [details]
Workaround for Linux

Michael can you take a look on this Linux-specific style?

The reason is for compatibility as I commented above. In a machine without X compositor they'd just see the border without background color.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Bug 1389416 - Match UITour's highlight with Photon's style.

Review commit: https://reviewboard.mozilla.org/r/168160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168160/

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Linux without X Compositor

This is the one with X-Compositor turned off.

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Linux without X Compositor

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8896871 [details]
Bug 1389416 - Match UITour's highlight with Photon's style.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168160/diff/1-2/

Comment 9

[:Gijs (he/him)]

Comment on attachment 8896871 [details]
Bug 1389416 - Match UITour's highlight with Photon's style.

https://reviewboard.mozilla.org/r/168160/#review173384

r=me assuming you get ui-review.

Comment 10

[:Gijs (he/him)]

It might be good to have a screenshot of what this looks like on the back button, too.

Comment 11

[Verdi [:verdi] Best to slack me]

Comment on attachment 8896882 [details]
Linux without X Compositor

That will work. Will we only show this to those linux users who can't have transparent colors?

Comment 12

[KM Lee [:rexboy] (inactivate after Sep. 22)]

(In reply to Verdi [:verdi] from comment #11)
> Comment on attachment 8896882 [details]
> Linux without X Compositor
> 
> That will work. Will we only show this to those linux users who can't have
> transparent colors?

From Firefox's side, it's unable to detect if they have X compositor or not. So for users on Linux who do have transparent color, they'll get transparent color + thick border, like another attachment I set ui-review to you. 
It's a little bit ugly than other OSes but I think we should try to keep the compatibility.

Comment 13

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: backbutton highlight

Left: X compositor on
Right: X compositor off

Comment 14

[KM Lee [:rexboy] (inactivate after Sep. 22)]

try running.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfd8b11bc6c1
Match UITour's highlight with Photon's style. r=Gijs

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cfd8b11bc6c1

Comment 17

[Abe - QA (:Abe_LV)]

Verified as fixed.

Comment 18

[Justin [:JW_SoftvisionQA]]

I have verified that the UITour's Highlight on Linux matches Photon's style on Ubuntu 16.04 x32 with Firefox 58.