Closed Bug 1389420 Opened 3 years ago Closed 3 years ago

[mozilla-release leftovers] Rename android-api-15 to android-api-16 once 56 reaches release

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(2 files, 2 obsolete files)

In bug 1384482, I discovered more leftovers. To sum up, we should change:
* mozilla-central/mozilla-beta: testing/mozharness/configs/merge_day/beta_to_release.py (see comment 0)
* buildbot-configs: We should get rid of that config dict[1] and remove api-15 from [2]
* buildbotcustom: We have to add 'mozilla-release' in this tuple[3] (mozilla-beta will be added in bug 1384482)
* releasetasks: Update releasetasks/release_configs/{dev,prod}_mozilla-beta_fennec_full_graph.yml just like in [4]

[1] https://hg.mozilla.org/build/buildbot-configs/rev/1aae6627103773857f7cf5d48a0f45c5ad7d0f33#l1.12
[2] https://hg.mozilla.org/build/buildbot-configs/rev/1aae6627103773857f7cf5d48a0f45c5ad7d0f33#l2.13
[3] https://hg.mozilla.org/build/buildbotcustom/rev/75f658918e77914a75099458f105bdf97542edb3#l1.14
[4] https://github.com/mozilla-releng/releasetasks/pull/269
Summary: merge_day/beta_to_release.py: Rename android-api-15 to android-api-16 once 57 reaches beta → [mozilla-release leftovers] Rename android-api-15 to android-api-16 once 56 reaches release
Attached patch bug1389420.patch (obsolete) — Splinter Review
I don't see the patch in 

[3] https://hg.mozilla.org/build/buildbotcustom/rev/75f658918e77914a75099458f105bdf97542edb3#l1.14

landed on bbcustom now

specifically, this, has it been backed out?
BRANCHES_WITH_API_LEVEL_16 = ('jamun',)
Flags: needinfo?(jlorenzo)
Attached patch bug1389420bbconfigs.patch (obsolete) — Splinter Review
not sure if android-x86 should be removed as well since my understanding is that it is tc on release as well.
Attached file pr
Comment on attachment 8906097 [details] [diff] [review]
bug1389420.patch

Sorry for the confusion, I forgot to update this bug, with the latest state of bug 1384482.

A few things aren't true anymore in comment 2:

> In bug 1384482, I discovered more leftovers. To sum up, we should change:
> * mozilla-central/mozilla-beta: testing/mozharness/configs/merge_day/beta_to_release.py (see comment 0)
That's still true. However, we need that patch before merge day. It doesn't require be landed. It just requires to be applied on the machine that perform the m-b => m-c migration.
I submitted a more up-to-date patch. The one in comment 1 is obsolete.

> * buildbot-configs: We should get rid of that config dict[1] and remove api-15 from [2]
Not valid anymore. Buildbot still uses api-15 to name slaves. Details are left in bug 1384482 comment 85.

> * buildbotcustom: We have to add 'mozilla-release' in this tuple[3] (mozilla-beta will be added in bug 1384482)
Not valid anymore, for the same reason as above

> * releasetasks: Update releasetasks/release_configs/{dev,prod}_mozilla-beta_fennec_full_graph.yml just like in [4]
Still valid and the patch looks good!
Attachment #8906097 - Attachment is obsolete: true
Flags: needinfo?(jlorenzo)
Attachment #8907807 - Attachment is obsolete: true
Attachment #8907821 - Flags: review+
Comment on attachment 8908029 [details]
Bug 1389420 - [mozilla-release leftovers] Rename android-api-15 to android-api-16 once 56 reaches release

https://reviewboard.mozilla.org/r/179712/#review185020

lgtm
Attachment #8908029 - Flags: review?(sfraser) → review+
This was marked as needed for Firefox 56.0 rc in release warrior, when it seems like it should have been for Fennec 56.0, so I've moved that in the FUTURE notes. Could we get a nice summary comment indicating exactly what needs to land ? That is super helpful when releaseduty doesn't have full context on the changes.
Pushed by jlorenzo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e10c49f7258a
[mozilla-release leftovers] Rename android-api-15 to android-api-16 once 56 reaches release r=sfraser
Woops, thanks for moving this requirement to the right file. I looked back at bug 1384482, I don't think we need more patches. I landed releasetasks at [1]. Gecko got checked in autoland.

Then, there is no further action required for releaseduty. 

[1] https://github.com/mozilla-releng/releasetasks/commit/ee2d9be35628083e6b3635a95c2a49f62cb6df69
https://hg.mozilla.org/mozilla-central/rev/e10c49f7258a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Assignee: nobody → jlorenzo
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.