1389433 - Text displays wrong with certain styles in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Ethan Lin[:ethlin]]

The test 'reftests/w3c-css/submitted/text-decor-3/text-emphasis-style-property-002.html'[1] can reproduce this problem. I guess the display item's boundary is wrong.

[1] https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/I3UAGPuwTZSS7V6gNOAdlA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1389433 - Fix the offset of the fallback image for layers-free.

Originally we use the nsDisplayItem::ToReferenceFrame() to get the offset. But the
function doesn't consider some style effects. We should take the top-left corner
of the display item bounds as the offset.

Review commit: https://reviewboard.mozilla.org/r/168172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168172/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8896881 [details]
Bug 1389433 - Fix the offset of the fallback image for layers-free.

https://reviewboard.mozilla.org/r/168172/#review173768

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15bf2faef292
Fix the offset of the fallback image for layers-free. r=mtseng

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15bf2faef292