Closed Bug 1389457 Opened 7 years ago Closed 7 years ago

(photon) On Android 4.4 devices, the private mode tabs counter icon is black

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

57 Branch
ARM
Android

Tracking

(fennec+, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: ohorvath, Assigned: jwu)

References

Details

(Whiteboard: [FNC][SPT57.2][MVP])

Attachments

(2 files)

Devices:
Prestigio Grace X5 (Android 4.4.2)
Lenovo Yoga Tablet 2 (Android 4.4.2)

Build: Nightly 57.0a1 (2017-08-11);

Steps to reproduce:
1. Open a tab in private mode.
2. Verify the tabs counter icon.

Expected result:
White icon on a dark background.

Actual result:
See screenshot. On Android 4.4 only, the icon is black on a dark background.
Assignee: nobody → topwu.tw
tracking-fennec: ? → +
Priority: -- → P1
Whiteboard: [FNC][SPT57.2][MVP]
Comment on attachment 8897661 [details]
Bug 1389457 - Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter.

https://reviewboard.mozilla.org/r/168694/#review174542
Attachment #8897661 - Flags: review?(cnevinchen) → review+
Comment on attachment 8897661 [details]
Bug 1389457 - Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter.

https://reviewboard.mozilla.org/r/168694/#review175150
Attachment #8897661 - Flags: review?(walkingice0204) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/079280757fe3
Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter. r=nechen,walkingice
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/079280757fe3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.