1389457 - (photon) On Android 4.4 devices, the private mode tabs counter icon is black

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P1)

Description

[Oana Horvath [:ohorvath - out of office]]

Attachment: Screenshot_2017-08-11-14-33-18.png

Devices:
Prestigio Grace X5 (Android 4.4.2)
Lenovo Yoga Tablet 2 (Android 4.4.2)

Build: Nightly 57.0a1 (2017-08-11);

Steps to reproduce:
1. Open a tab in private mode.
2. Verify the tabs counter icon.

Expected result:
White icon on a dark background.

Actual result:
See screenshot. On Android 4.4 only, the icon is black on a dark background.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1389457 - Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter.

gecko:drawableTintList doesn't support background tint in Android 4.4.
The solution replaces it with ThemedImageView, then we can tint foreground instead of background.

Review commit: https://reviewboard.mozilla.org/r/168694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168694/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8897661 [details]
Bug 1389457 - Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter.

https://reviewboard.mozilla.org/r/168694/#review174542

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8897661 [details]
Bug 1389457 - Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter.

https://reviewboard.mozilla.org/r/168694/#review175150

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/079280757fe3
Use ThemedImageView instead of ThemedFrameLayout to compose TabCounter. r=nechen,walkingice

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/079280757fe3