Closed
Bug 1389503
Opened 7 years ago
Closed 7 years ago
Don't fail when an SVG is not found
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
Firefox 57
People
(Reporter: jlast, Assigned: jlast)
Details
Attachments
(1 file, 2 obsolete files)
1.01 KB,
patch
|
bgrins
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We currently fail when we can't find an SVG. This is causing an issue for angular usage, where we currently look for an SVG we can't find.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8896347 -
Flags: review?(jdescottes)
Assignee | ||
Comment 2•7 years ago
|
||
Approval Request Comment [Feature/Bug causing the regression]:1389503 [User impact if declined]: angular applications won't be debuggable [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: it removes a throw [String changes made/needed]:
Attachment #8896349 -
Flags: review?(jdescottes)
Attachment #8896349 -
Flags: approval-mozilla-beta?
Comment 3•7 years ago
|
||
Which versions are affected? Do we know a regression window? (It doesn't make sense for this bug to have caused the regression)
Flags: needinfo?(jlaster)
Comment 4•7 years ago
|
||
Assuming nightly is affected.
Assignee | ||
Comment 5•7 years ago
|
||
Sorry :lizzard, that was not clear. This bug introduced it: https://bugzilla.mozilla.org/show_bug.cgi?id=1385421 We have fixed the problem on nightly by already landing a patch.
Flags: needinfo?(jlaster)
Assignee | ||
Comment 6•7 years ago
|
||
:lizzard, looks like the nightly patch did not land yet either. I'll get it reviewed shortly.
Assignee | ||
Comment 7•7 years ago
|
||
same comments from above
Attachment #8896347 -
Attachment is obsolete: true
Attachment #8896349 -
Attachment is obsolete: true
Attachment #8896347 -
Flags: review?(jdescottes)
Attachment #8896349 -
Flags: review?(jdescottes)
Attachment #8896349 -
Flags: approval-mozilla-beta?
Attachment #8897479 -
Flags: review?(bgrinstead)
Attachment #8897479 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cdc2e53fa062e23d5f3ef68c8e0f1853fa65de6
Assignee | ||
Comment 9•7 years ago
|
||
It's easy to test this by going to todomvc.com/examples/angularjs/ and adding a breakpoint
Updated•7 years ago
|
Attachment #8897479 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/643363573c85 Don't fail when an SVG is not found. r=jdescottes
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/643363573c85
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Updated•7 years ago
|
Comment 12•7 years ago
|
||
Comment on attachment 8897479 [details] [diff] [review] svg1.patch Fix a devtools issue. Beta56+.
Attachment #8897479 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/1e2abdc98512
Comment 14•7 years ago
|
||
(In reply to Jason Laster [:jlast] from comment #2) > [Is this code covered by automated tests?]: yes > [Has the fix been verified in Nightly?]: no > [Needs manual test from QE? If yes, steps to reproduce]: no Setting qe-verify- based on Jason's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•