Closed Bug 1389503 Opened 8 years ago Closed 8 years ago

Don't fail when an SVG is not found

Categories

(DevTools :: Debugger, defect)

Product:
DevTools
Component:
Debugger
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox56 fixed, firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 2 obsolete files)

svg1.patch
1.01 KB, patch
bgrins
: review+
gchang
: approval-mozilla-beta+
Details | Diff | Splinter Review
We currently fail when we can't find an SVG. This is causing an issue for angular usage, where we currently look for an SVG we can't find.
Attached patch svg1.patch (obsolete) — — Splinter Review
Attachment #8896347 - Flags: review?(jdescottes)
Attached patch svg1.patch (obsolete) — — Splinter Review
Approval Request Comment [Feature/Bug causing the regression]:1389503 [User impact if declined]: angular applications won't be debuggable [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: it removes a throw [String changes made/needed]:
Attachment #8896349 - Flags: review?(jdescottes)
Attachment #8896349 - Flags: approval-mozilla-beta?
Which versions are affected? Do we know a regression window? (It doesn't make sense for this bug to have caused the regression)
Flags: needinfo?(jlaster)
Assuming nightly is affected.
Assignee: nobody → jlaster
status-firefox56: --- → ?
status-firefox57: --- → affected
Sorry :lizzard, that was not clear. This bug introduced it: https://bugzilla.mozilla.org/show_bug.cgi?id=1385421 We have fixed the problem on nightly by already landing a patch.
Flags: needinfo?(jlaster)
:lizzard, looks like the nightly patch did not land yet either. I'll get it reviewed shortly.
Attached patch svg1.patch — — Splinter Review
same comments from above
Attachment #8896347 - Attachment is obsolete: true
Attachment #8896349 - Attachment is obsolete: true
Attachment #8896347 - Flags: review?(jdescottes)
Attachment #8896349 - Flags: review?(jdescottes)
Attachment #8896349 - Flags: approval-mozilla-beta?
Attachment #8897479 - Flags: review?(bgrinstead)
Attachment #8897479 - Flags: approval-mozilla-beta?
It's easy to test this by going to todomvc.com/examples/angularjs/ and adding a breakpoint
Attachment #8897479 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/643363573c85 Don't fail when an SVG is not found. r=jdescottes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/643363573c85
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment on attachment 8897479 [details] [diff] [review] svg1.patch Fix a devtools issue. Beta56+.
Attachment #8897479 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Jason Laster [:jlast] from comment #2) > [Is this code covered by automated tests?]: yes > [Has the fix been verified in Nightly?]: no > [Needs manual test from QE? If yes, steps to reproduce]: no Setting qe-verify- based on Jason's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: