1389579 - |mach lint| doesn't print the offending line for lint violations

Status: NEW

(Developer Infrastructure :: Lint and Formatting, enhancement, P3)

Description

[Eric Rahm [:erahm]]

Calling |mach lint| outputs the 'line:col file' but doesn't actually print the offending line. It would make deciphering what went wrong easier if we included the contents of the line (similar to clang & gcc).

Comment 1

[Dave Townsend [:mossop]]

I know that eslint supports programmable output formatters so in theory we could make eslint output whatever we wanted to. It looks like the codeframe formatter might be a better choice: http://eslint.org/docs/user-guide/formatters/#codeframe

Comment 2

[Andrew Halberstadt [:ahal]]

We don't actually use the eslint formatters per se. ESlint outputs the json format and mozlint handles the formatting:
https://dxr.mozilla.org/mozilla-central/search?q=path:python%2Fmozlint%2Fmozlint%2Fformatters

The good news is we can implement this pretty easily. We could either add source context to the stylish formatter (I have a patch lying around that already does this), implement a new codeframe formatter, or both.