Closed Bug 1389681 Opened 7 years ago Closed 7 years ago

stylo: Move NoteDirty* from nsIContent to Element and stop doing style traversals for text node insertions

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

I was going to do this in bug 1389385, but I was getting timeouts, and I think bug 1388031 may solve them. So I'm separating it out into a separate bug.

Try push with the timeouts: https://treeherder.mozilla.org/#/jobs?repo=try&revision=128a7ebb742d4f1cbe89de51ec9e8b2bc2caebb6
Flags: needinfo?(bobbyholley)
(Specifically, my theory is that we're doing a throttled animation flush, which doesn't find the lazy frame construction, and so we get stuck in an infinite loop. Bug 1388031 gets rid of throttled animation flushes, so the problem should go away).
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #1)
> (Specifically, my theory is that we're doing a throttled animation flush,
> which doesn't find the lazy frame construction, and so we get stuck in an
> infinite loop. Bug 1388031 gets rid of throttled animation flushes, so the
> problem should go away).

Yep: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9c24b75615ecceb16a12893e2c3b7469912b7e4
Flags: needinfo?(bobbyholley)
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b67c04329259
Move NoteDirty* to Element. r=emilio
https://hg.mozilla.org/mozilla-central/rev/b67c04329259
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.