1389710 - Default search engines are displayed with huge icons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Grisha Kruglov]

Attachment: Screenshot_20170811-181308.png

Likely fallout from Photon work - but I didn't check that, so feel free to correct me. See screenshot.

Also, see Bug 1389709 about the fact that there are only three search engines in the list!

Comment 1

[Jan Henning [:JanH]]

Not just in the settings, but when actually searching from the URL bar as well.

Comment 2

[Jing-wei Wu [:jwu]]

Looks like this issue is caused by bug 1383736, the value of favicon_bg in dimens.xml is changed from '32dp' to '112dp'.

https://dxr.mozilla.org/mozilla-central/source/mobile/android/app/src/australis/res/values/dimens.xml#59

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Yep, that's a regression from the AS icon work. Seems like those layouts do not set limits.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: Bug 1389710 - Search engine preference: Use "favicon_small_size" (like in two_line_page_row.xml).

Review commit: https://reviewboard.mozilla.org/r/173280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173280/

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8901846 [details]
Bug 1389710 - Search engine preference: Use "favicon_small_size" (like in two_line_page_row.xml).

https://reviewboard.mozilla.org/r/173280/#review179150

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bafa21bbd99
Search engine preference: Use "favicon_small_size" (like in two_line_page_row.xml). r=mcomella

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9bafa21bbd99

Comment 8

[Oana Horvath [:ohorvath]]

Verified as fixed on Nighlty (2017-09-20).
Devices:
Xiaomi Mi Pad 2 (Android 5.1) 
Lenovo Yoga Tablet 2 (Android 4.4.2)
LG G4 (Android 6.0)