1389752 - Throw TypeError if proxy [[OwnPropertyKeys]] returns duplicate entries

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement)

Description

[Tom S. (please needinfo tschuster)]

This semantically reverts bug 1293995, which wasn't a very good idea. We have to throw an error after CreateFilteredListFromArrayLike, so maybe we should modify that function to use an additional HashSet.

Comment 1

[André Bargull [:anba]]

Attachment: bug1389752.patch

This merges step 9 and step 18, so we can directly detect duplicates when creating the |uncheckedResultKeys| set.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8900488 [details] [diff] [review]
bug1389752.patch

Review of attachment 8900488 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this shouldn't even make Proxy.[[OwnPropertyKeys]]() all that much slower.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5431abd21fe7832cc566aa5fd05d67e091676bf4

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/57ec52606739
Throw TypeError if [[OwnPropertyKeys]] of scripted proxies contains duplicates. r=till

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing web-platform-tests' /fetch/api/headers/headers-record.html:

https://hg.mozilla.org/integration/mozilla-inbound/rev/030e166c812c60064543baa102b8011f31684a5f

Push which ran failing tests: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c216b1ee565e736235b57e60c0754331af3f20e0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=125901705&repo=mozilla-inbound

[task 2017-08-25T13:08:14.698872Z] 13:08:14     INFO - TEST-PASS | /fetch/api/headers/headers-record.html | Correct operation ordering with non-enumerable properties 
[task 2017-08-25T13:08:14.699104Z] 13:08:14     INFO - TEST-PASS | /fetch/api/headers/headers-record.html | Correct operation ordering with undefined descriptors 
[task 2017-08-25T13:08:14.699413Z] 13:08:14     INFO - TEST-UNEXPECTED-FAIL | /fetch/api/headers/headers-record.html | Correct operation ordering with repeated keys - proxy [[OwnPropertyKeys]] can't report property '"a"' more than once
[task 2017-08-25T13:08:14.699684Z] 13:08:14     INFO - loggingHandler[prop]@http://web-platform.test:8000/fetch/api/headers/headers-record.html:22:28
[task 2017-08-25T13:08:14.699911Z] 13:08:14     INFO - @http://web-platform.test:8000/fetch/api/headers/headers-record.html:275:11
[task 2017-08-25T13:08:14.700207Z] 13:08:14     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1441:20
[task 2017-08-25T13:08:14.700393Z] 13:08:14     INFO - test@http://web-platform.test:8000/resources/testharness.js:501:9
[task 2017-08-25T13:08:14.700714Z] 13:08:14     INFO - @http://web-platform.test:8000/fetch/api/headers/headers-record.html:247:1
[task 2017-08-25T13:08:14.701252Z] 13:08:14     INFO - ..

Comment 6

[André Bargull [:anba]]

Attachment: bug1389752-part2-update-wpt.patch

With the new Proxy [[OwnPropertyKeys]] restriction to disallow duplicate property keys, large parts of the test are no longer valid. There are only three things we can test now:
- The [[Get]] trap for @@iterator is called
- The [[OwnPropertyKeys]] is called
- And a TypeError is thrown

Comment 7

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7bbbddc2f640893b85752c47d3abb559bb929055

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9affea4e745f
Throw TypeError if [[OwnPropertyKeys]] of scripted proxies contains duplicates. r=till, r=qdot

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9affea4e745f