1389861 - Remove extra serialization/deserialization overhead from same-process policy initialization

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Kris Maglione [:kmag]]

We currently serialize and deserialize extension data that we use to initialize policy objects when setting them up in the parent process. This overhead is unnecessary, and simple enough to remove.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1389861: Remove needless overhead from same-process policy initialization.

Review commit: https://reviewboard.mozilla.org/r/167972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167972/

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8896665 [details]
Bug 1389861: Remove needless overhead from same-process policy initialization.

https://reviewboard.mozilla.org/r/167972/#review173148

::: toolkit/components/extensions/extension-process-script.js:59
(Diff revision 1)
>  }
>  
>  var extensions = new DefaultWeakMap(policy => {
> -  let extension = new ExtensionChild.BrowserExtensionContent(policy.initData);
> +  let data = policy.initData;
> +  if (data.serialize) {
> +    data = data.serialize();

nit: could use a comment as well.

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca3247d2f8b3be150510b910f2d7583a5b43eea
Bug 1389861: Remove needless overhead from same-process policy initialization. r=zombie

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ca3247d2f8b
Remove needless overhead from same-process policy initialization. r=zombie

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5ca3247d2f8b