Create bootstrap Sandboxes without indexedDB constructor by default

RESOLVED FIXED in Firefox 57

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [qf:p3])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

We currently spend several milliseconds at startup creating these bindings, despite the fact that they're never used.
Comment hidden (mozreview-request)

Comment 2

6 months ago
Is this going to break anything in test pilot?
Flags: needinfo?(wclouser)
Flags: needinfo?(jhirsch)
Thanks for the ping.  This doesn't affect Test Pilot or any active experiments right now.  :jkt was saying it will affect the new lightbeam add-on though (not a test pilot experiment)
Flags: needinfo?(wclouser)
Flags: needinfo?(jkt)
Flags: needinfo?(jhirsch)
If any extensions need an indexedDB constructor from a bootstrap sandbox, they can import it explicitly using Cu.importGlobalProperties. I'd be surprised if they actually used it directly from a bootstrap sandbox rather than a JSM, though.
The new Lightbeam is a web extension, the old isn't I think we are fine here.
Thanks :clouserw
Flags: needinfo?(jkt)

Comment 6

6 months ago
mozreview-review
Comment on attachment 8896672 [details]
Bug 1389868: Create bootstrap Sandboxes without indexedDB constructor by default.

https://reviewboard.mozilla.org/r/167982/#review173606
Attachment #8896672 - Flags: review?(aswan) → review+
Whiteboard: [qf] → [qf:p3]

Comment 7

6 months ago
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cde80c96f44
Create bootstrap Sandboxes without indexedDB constructor by default. r=aswan

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8cde80c96f44
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.