Closed Bug 1389868 Opened 4 years ago Closed 4 years ago

Create bootstrap Sandboxes without indexedDB constructor by default

Categories

(Toolkit :: Add-ons Manager, enhancement)

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qf:p3])

Attachments

(1 file)

Bug 1389868: Create bootstrap Sandboxes without indexedDB constructor by default.
59 bytes, text/x-review-board-request
aswan
: review+
Details 
We currently spend several milliseconds at startup creating these bindings, despite the fact that they're never used.
Is this going to break anything in test pilot?
Flags: needinfo?(wclouser)
Flags: needinfo?(jhirsch)
Thanks for the ping.  This doesn't affect Test Pilot or any active experiments right now.  :jkt was saying it will affect the new lightbeam add-on though (not a test pilot experiment)
Flags: needinfo?(wclouser)
Flags: needinfo?(jkt)
Flags: needinfo?(jhirsch)
If any extensions need an indexedDB constructor from a bootstrap sandbox, they can import it explicitly using Cu.importGlobalProperties. I'd be surprised if they actually used it directly from a bootstrap sandbox rather than a JSM, though.
The new Lightbeam is a web extension, the old isn't I think we are fine here.
Thanks :clouserw
Flags: needinfo?(jkt)
Comment on attachment 8896672 [details]
Bug 1389868: Create bootstrap Sandboxes without indexedDB constructor by default.

https://reviewboard.mozilla.org/r/167982/#review173606
Attachment #8896672 - Flags: review?(aswan) → review+
Whiteboard: [qf] → [qf:p3]
Pushed by maglione.k@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cde80c96f44
Create bootstrap Sandboxes without indexedDB constructor by default. r=aswan
https://hg.mozilla.org/mozilla-central/rev/8cde80c96f44
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.