1389870 - Context Menu Text Changes Color After Loading Webpage

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[pringo4]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170809080026

Steps to reproduce:

Steps to reproduce:

1. Load http://www.anandtech.com/
2. Load http://www.anandtech.com/show/11697/the-amd-ryzen-threadripper-1950x-and-1920x-review
3. Load http://www.anandtech.com/show/11697/the-amd-ryzen-threadripper-1950x-and-1920x-review/7 
through the selection on the previous page.
4. Now right click the tab of the page and the context menu text is now teal colored.

Image of issue: https://i.imgur.com/d2sbMaD.png


Actual results:

The context menu text changed color.


Expected results:

The context menu text should remain black.

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]: At least, UI is broken due to Web Site. Lack of product reliability.

STR
1. Make sure e10s is enabled
2. Open http://www.anandtech.com/show/11697/the-amd-ryzen-threadripper-1950x-and-1920x-review/7
3. Click <select> tag 
4. Open any menu popup such as contextmenu(Tab/LocationBar/SearchBar etc, except contentarea) and main menu in　Menubar


Regression window:
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=2255dbea626873d861e8031726ec120468c7923e&tochange=d553313466297741d50c810b95bd9685524dd461

Regressed by: Bug 1291515

Comment 2

[Cameron McCormack (:heycam)]

Is this different from bug 1388682?

Comment 3

[Alice0775 White]

Maybe same root cause.

However,

* The problem arises on the modern OS(Windows10).
* The web page influences the behavior of the browser UI.

This means Firefox has a potential vulnerability.

Comment 4

[Cameron McCormack (:heycam)]

That it affects other popups is concerning, you're right.  Sylvestre, do you think this is important enough to uplift bug 1375224 to release?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Yeah probably

Comment 6

[Cameron McCormack (:heycam)]

Another option would be just to uplift a re-enabling of <style scoped>.  That would be safer, for Release.  (Is there some simpler way to push pref updates to Release?  I'm not sure.)  David, what do you think?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

The fix is the same as bug 1388682, uplifting bug 1375224, which should have been uplifted with the disabling of <style scoped>.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

I have requested uplift to release in bug 1375224 which I have confirmed will fix this.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Cameron McCormack (:heycam) from comment #6)
> Another option would be just to uplift a re-enabling of <style scoped>. 
> That would be safer, for Release.  (Is there some simpler way to push pref
> updates to Release?  I'm not sure.)  David, what do you think?

I think if we want to fix something sooner, it might be worth pushing the pref flip (until we next ship more bits to release), which I think can be done without shipping a release, but it's probably better to push the patch and get more testing of style-scoped-disabled.  However, pushing the pref flip may well not be worth it depending on what our shipping plans are.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

We are going to ship Wednesday a 55.0.2 version.
Not tracking as we already landed the fix in the other bug

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

This was fixed by bug 1375224.