1389888 - include/nsTArray.h: Attempt to free non-heap object (multiple occurences)

Status: UNCONFIRMED

(Core :: XPCOM, enhancement, P5)

Description

[Anton Kochkov]

* QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'temp' [-Wfree-nonheap-object]
 * 
/var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/media/mtransport/third_party/nICEr/src/ice/ice_media_stream.c:730:5: 
warning: implicit declaration of function 'nr_ice_component_consent_destroy' [-Wimplicit-function-declaration]
 * 
/var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/media/mtransport/third_party/nICEr/src/stun/stun_client_ctx.c:256:5: 
warning: implicit declaration of function 'nr_ice_accumulate_count' [-Wimplicit-function-declaration]
 * 
/var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/media/mtransport/third_party/nICEr/src/stun/turn_client_ctx.c:260:9: 
warning: implicit declaration of function 'nr_ice_accumulate_count' [-Wimplicit-function-declaration]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'results' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'hyphenBuffer' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg0' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg1' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg0' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg4' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg2' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'arg0' [-Wfree-nonheap-object]
 * /var/tmp/portage/www-client/firefox-55.0.1/work/firefox-55.0.1/ff/dist/include/nsTArray.h:200:44: warning: 
attempt to free a non-heap object 'temp' [-Wfree-nonheap-object]

Comment 1

[Blake Wu [:bwu][:blakewu]]

It looks like related to WebRTC.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

hyphenBuffer, referenced above, is only in gfx/thebes/gfxTextRun.cpp, so I don't think this has anything to do with WebRTC/mtransport.  I see nothing tracking the nsTArray warning back to the build warning about nICEr implicitly declaring a function.

I think there's something wrong with the compiler warning; perhaps something in nsTArray.h is confusing the warning code. (Perhaps with AutoTArrays?)

How are you generating those warnings?  What compiler/OS version?

Tentatively moving to XPCOM.

Comment 3

[Nathan Froyd [:froydnj]]

Tentatively saying this warning is bogus.  If it isn't bogus, then it is unactionable in its current state, because the warning isn't pointing at the actual code that's bogus, just some nsTArray template code.  We'd at least need to know what directories these warnings trigger in to have any hope of resolving the issue.

Comment 4

[Anton Kochkov]

It is Gentoo with GCC 4.9.4 version. I'll try to build firefox again and save the full build log.