Closed Bug 1389905 Opened 3 years ago Closed 3 years ago

Useless call on GetCurrentReferenceFrame from BuildDisplayListForChildren

Categories

(Core :: Panning and Zooming, enhancement, P3)

55 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1416400])

Attachments

(1 file)

"side_effect_free: Calling aBuilder->GetCurrentReferenceFrame() is only useful for its return value, which is ignored."

  const nsIFrame* GetCurrentReferenceFrame() { return mCurrentReferenceFrame; }
Assignee: nobody → sledru
Comment on attachment 8896706 [details]
Bug 1389905 - Remove an useless call on GetCurrentReferenceFrame from BuildDisplayListForChildren

https://reviewboard.mozilla.org/r/168006/#review173618

Huh. Not sure how that snuck in. Thanks for removing it!
Attachment #8896706 - Flags: review?(botond) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfb31e1b71f3
Remove an useless call on GetCurrentReferenceFrame from BuildDisplayListForChildren r=botond
https://hg.mozilla.org/mozilla-central/rev/bfb31e1b71f3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.