Open Bug 1389912 Opened 7 years ago Updated 2 years ago

Extension icon is too big and should be smaller

Categories

(Firefox :: Site Identity, defect, P3)

Product:
Firefox
Component:
Site Identity
Version:
57 Branch
Platform:
x86_64
Windows 7
Type:
defect

Tracking

()

People

(Reporter: Virtual, Unassigned)

References

Details

(Keywords: nightly-community, ux-consistency)

Attachments

(8 files)

screenshot.png
1.72 KB, image/png
Details
screenshot (500%).png
3.58 KB, image/png
Details
bad.png
1.01 KB, image/png
Details
good.png
1.16 KB, image/png
Details
Extension Icon
3.89 KB, image/png
Details
extensions - extension.png
189 bytes, image/png
Details
extensions - information.png
204 bytes, image/png
Details
Extension and Identity
12.24 KB, image/png
Details
Attached image screenshot.png —
Extension icon is too big and should be smaller Because for now: 14 x 14 px - "i" information icon size 16 x 16 px - extension icon size
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → Windows 7
QA Contact: Virtual
Hardware: Unspecified → x86_64
Whiteboard: [photon] [triage] → [photon-visual] [triage]
Flags: qe-verify+
Whiteboard: [photon-visual] [triage]
We've already triaged this. We're not going to change this icon as part of photon.
No longer blocks: photon-visual
Whiteboard: [photon-visual] [triage]
Priority: -- → P3
See Also: → 1391941
FYI - Photon redesign made changes to extension icon good icon - when installing extensions bad icon - when opening extensions options
I don't think we need to track the status of this version by version. It isn't likely to go away unless we find time to fix the bug or someone contributes a patch. Whilst I appreciate the checking, the status changing is just adding unnecessary noise here.
status-firefox63: affected → ---
status-firefox64: affected → ---
status-firefox65: affected → ---
status-firefox-esr60: affected → ---

Hi,

I'd like to work on this bug. This is my first bug, not sure if its a good first one but I'd like to fix it as part of my software engineering course at U of T.

Do you guys have any tips on how to get started, or what files I should start looking at?

Thanks
Samuel

Since this is not a high priority bug, regression, or security issue, it's not necessary to track status on this.

(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #0)

Created attachment 8896714 [details]
screenshot.png

Extension icon is too big and should be smaller

Because for now:
14 x 14 px - "i" information icon size
16 x 16 px - extension icon size

Hi, currently both are 16 x 16

Flags: needinfo?(Virtual)

I can't confirm this as I can still reproduce bug on Windows 7 (64-bit) with Mozilla Firefox Nightly 67.0a1 (2019-03-12) (64-bit).

Flags: needinfo?(Virtual)

I'm curious how it looks like on your end. Can you please post screenshot?

Flags: needinfo?(ijawadak)
Attached image Extension Icon —
Flags: needinfo?(ijawadak) → needinfo?(Virtual)

Odd, in your case I'm also seeing that extension icon is 16 x 16 px and "i" information is 14 x 14 px, same as on my screenshots.

Attached image Extension and Identity —

This looks like the resolution of both icons is same on files but there is difference of size if you open them side by side as seen in the screenshot. I think the extension icon needs to be resized just like the identity icon.

Flags: needinfo?(Virtual)

If resolution of both icons is same in files, but different in rendering, I suspect that there is somewhere some bigger issue hidden beneath. Still, your way of fixing could be fastest and simplest workaround, but I'm not proper person to address and answer this, on how you should proceed further.

Flags: needinfo?(Virtual)
Component: Address Bar → Site Identity and Permission Panels
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: