Closed Bug 1389915 Opened 2 years ago Closed 2 years ago

SOCKSv5 proxy has no "use remote DNS" option

Categories

(Thunderbird :: Preferences, defect)

52 Branch
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: hong, Assigned: Paenglab)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170808215255

Steps to reproduce:

Go to preferences, Advanced, Settings.... The network settings dialog pops up.


Actual results:

 There is no option, like in Firefox, named "Proxy DNS when using SOCKSv5."


Expected results:

 There is an option, like in Firefox, named "Proxy DNS when using SOCKSv5."
Richard, could you please investigate what's behind that FF option. Maybe we can add it easily.
Flags: needinfo?(richard.marti)
I think, we can add it easily as they point to toolkit network options (the "Do not prompt for authentication if password is saved" is also missing.

Hong Xu, before we add these options, please can you check if they are working? I have no proxy to test.

You can go to Preferences, Advanced, Genereal and open the config editor and change the by entering "network.proxy.socks_remote_dns" in the search field and then double clock on the result below to enable/disable it. And for the authentication it would be "signon.autologin.proxy".
Flags: needinfo?(richard.marti) → needinfo?(hong)
(In reply to Richard Marti (:Paenglab) from comment #2)
> Hong Xu, before we add these options, please can you check if they are
> working? I have no proxy to test.
> 
> You can go to Preferences, Advanced, Genereal and open the config editor and
> change the by entering "network.proxy.socks_remote_dns" in the search field
> and then double clock on the result below to enable/disable it. And for the
> authentication it would be "signon.autologin.proxy".

Yes, I can confirm that "network.proxy.socks_remote_dns" works, but seems restarting Thunderbird is required to make it take effect.
Flags: needinfo?(hong)
OK, we can add the option to the UI, but in the meantime, you know what to do.
Attached patch proxy.patchSplinter Review
This adds the two checkboxes. I had to use the same, not optimal, accesskey "i" as FX as all other keys are used (especially in prefsintab mode).

I also added the dialog width from FX to make the dialog better looking.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #8896965 - Flags: review?(jorgk)
Comment on attachment 8896965 [details] [diff] [review]
proxy.patch

Review of attachment 8896965 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: mail/locales/en-US/chrome/messenger/preferences/connection.dtd
@@ +43,5 @@
> +<!ENTITY  autologinproxy.label          "Do not prompt for authentication if password is saved">
> +<!ENTITY  autologinproxy.accesskey      "i">
> +<!ENTITY  autologinproxy.tooltip        "This option silently authenticates you to proxies when you have saved credentials for them. You will be prompted if authentication fails.">
> +<!ENTITY  socksRemoteDNS.label          "Proxy DNS when using SOCKS v5">
> +<!ENTITY  socksRemoteDNS.accesskey      "d">

That's not an upper case "d"?
Attachment #8896965 - Flags: review?(jorgk) → review+
(In reply to Jorg K (GMT+2) from comment #6)
> Comment on attachment 8896965 [details] [diff] [review]
> proxy.patch
> 
> Review of attachment 8896965 [details] [diff] [review]:
> -----------------------------------------------------------------
> ::: mail/locales/en-US/chrome/messenger/preferences/connection.dtd
> > +<!ENTITY  socksRemoteDNS.label          "Proxy DNS when using SOCKS v5">
> > +<!ENTITY  socksRemoteDNS.accesskey      "d">
> 
> That's not an upper case "d"?

The <!ENTITY  systemTypeRadio.accesskey "u"> is also lower case and works on the upper case "Use system..."
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4ddeb9d0bb82
Add "Proxy DNS when using SOCKS v5" and "Do not prompt for authentication if password is saved" to connection prefs dialog. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.