Closed Bug 1389940 Opened 2 years ago Closed 2 years ago

Remove "firefox" from the string in about:telemetry

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18))
> ::: toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd:24
> (Diff revision 8)
> >  <!ENTITY aboutTelemetry.raw "
> >  Raw JSON
> >  ">
> >  
> > +<!ENTITY aboutTelemetry.showInFirefoxJsonViewer "
> > +Open in the firefox JSON viewer
> 
> You really don't want Firefox lowercase in a string.
> 
> No need to udpate the string ID, just fix the string directly.
> On second thoughts, I'm not sure you even want to call out "Firefox" in such string?
Comment on attachment 8896761 [details]
Bug 1389940 - Remove "firefox" from the string in about:telemetry

https://reviewboard.mozilla.org/r/168040/#review173508
Attachment #8896761 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/21d5f97539a8
Remove "firefox" from the string in about:telemetry r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/21d5f97539a8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18) from comment #15)
> You really don't want Firefox lowercase in a string.
> 
> No need to udpate the string ID, just fix the string directly.

That was for changing "firefox" to "Firefox", not removing it…

It didn't help that you merged two separate comments into one here, nor CCed me to this bug.

At this point, leave the string as it is, but next time please let's avoid this.
You need to log in before you can comment on or make changes to this bug.