1389940 - Remove "firefox" from the string in about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[flyingrub]

(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18))
> ::: toolkit/locales/en-US/chrome/global/aboutTelemetry.dtd:24
> (Diff revision 8)
> >  <!ENTITY aboutTelemetry.raw "
> >  Raw JSON
> >  ">
> >  
> > +<!ENTITY aboutTelemetry.showInFirefoxJsonViewer "
> > +Open in the firefox JSON viewer
> 
> You really don't want Firefox lowercase in a string.
> 
> No need to udpate the string ID, just fix the string directly.
> On second thoughts, I'm not sure you even want to call out "Firefox" in such string?

Comment 1

[flyingrub]

Attachment: Bug 1389940 - Remove "firefox" from the string in about:telemetry

Review commit: https://reviewboard.mozilla.org/r/168040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168040/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8896761 [details]
Bug 1389940 - Remove "firefox" from the string in about:telemetry

https://reviewboard.mozilla.org/r/168040/#review173508

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21d5f97539a8
Remove "firefox" from the string in about:telemetry r=chutten

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21d5f97539a8

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] (traveling, slow reply until Aug 18) from comment #15)
> You really don't want Firefox lowercase in a string.
> 
> No need to udpate the string ID, just fix the string directly.

That was for changing "firefox" to "Firefox", not removing it…

It didn't help that you merged two separate comments into one here, nor CCed me to this bug.

At this point, leave the string as it is, but next time please let's avoid this.