Steps: 1. Load https://meet.jit.si/untranslated Result: The door hanger has the word "default:" in es-MX and it Nightly. Expected result: The door hanger has the word localized.
Looks like it's coming from here http://searchfox.org/mozilla-central/source/dom/media/MediaManager.cpp#2076
Looks like it's from http://searchfox.org/mozilla-central/rev/c81edf03152b08b0f1d095c68b0dea7a5d7285ce/media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc#1942 but if so it's Linux-only.
I'm seeing it on Mac, and Alex on Windows 10.
Summary: "dafault" is untranslated on "Device Permissions" door hanger → "default" is untranslated on "Device Permissions" door hanger
Is someone going to fix this in time for 57?
This is not a regression AFAIK. I tried FF44 /es-ES/, which predates bug 1221587, and it says "default (micrófono integrado)". I suspect it's been like this since we added mic support, so fixing this seems less urgent. What appears to have changed is the formatting. We now say "default: micrófono integrado", which seems inferior to me. Florian, do you recall if this was on purpose? I'm on a MBP where the OS system choice tends to be the integrated mic or headset, both of which OSX translate. On desktops without integrated mic (e.g. Windows), we likely wouldn't be seeing a language mix or locale-translated device name, which means translating "default" would add locale differences where there was none before. Also this isn't strictly a UX issue since the value is exposed to the web through track.label and enumerateDevices: http://jsfiddle.net/jib1/ex0xr8rr/ https://webrtc.github.io/samples/src/content/devices/input-output/ This means every time we change it, we may cause some sites to forget a user's mic choice, if they use track.label for this (they should be using deviceId for this, but can't because of bug 1398180). Minor perhaps, and we appear to have changed it once already, but worth noting because of my recommendation at the end. The last complication is that "default" isn't a very good word here to begin with. Nevermind it being a computer programming term, and hard to translate (it's not "defecto" as google translate thinks), it's not even the right programming term. It DOESN'T mean this is the default choice in this list, though it tends to be. Rather, it's a distinct device representing whatever the end-user-chosen value is in System Preferences at the OS level, the OS "default" from the viewpoint of a program. Better terms may be: System (integrated microphone) System setting (integrated microphone) System choice (integrated microphone) Yes I prefer the parens, as the values inside parens may change from invocation to invocation (maybe even live), which is the whole point of keeping this otherwise redundant choice. But 57 may not be the best time to have this conversation, so I suggest we fix this the right way sometime after 57, and not break web sites by changing this string more than once more.
Flags: needinfo?(jib) → needinfo?(florian)
Summary: "default" is untranslated on "Device Permissions" door hanger → "default" is untranslated on "Device Permissions" door hanger and in JS APIs
Yes, this is all not very good. We'll fix it when fixing all the other things.
(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #7) > I suspect it's been like this since we added mic support, so fixing this > seems less urgent. > What appears to have changed is the formatting. We now say "default: > micrófono integrado", which seems inferior to me. Florian, do you recall if > this was on purpose? I don't remember, sorry.
You need to log in before you can comment on or make changes to this bug.