1389996 - Artifact builds are going to permafail when Gecko 57 merges to Beta on 2017-09-14

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Broken artifact builds on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=122803886&repo=try

INFO -  checking for the target C compiler... not found
INFO -  DEBUG: _cc: Trying /home/worker/workspace/build/src/gcc/bin/gcc
INFO -  ERROR: Cannot find the target C compiler
INFO -  *** Fix above errors and then restart with\
INFO -                 "/usr/local/bin/gmake -f client.mk build"
INFO -  client.mk:382: recipe for target 'configure' failed
INFO -  gmake: *** [configure] Error 1

Comment 1

[Mike Hommey [:glandium]]

That build is using the "beta" mozconfig. On m-c, artifact builds use a separate mozconfig, not "nightly". One more reason bug 1372697 needs to be fixed. In the meanwhile, this means beta needs to be adapted to use a separate mozconfig for artifact builds too.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

We should just hide or disable artifact builds on beta for now. I don't think we're landing enough build system work directly on beta to pose a significant risk to them there.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Isn't the gist here that they won't work *at all*? Are we saying that they just won't be supported on Beta? If so, yes, we should turn them off. If they're expected to work, I don't know why this bug wouldn't need fixing.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

From reading the log of the failure it appears they're mis-configured on beta in some fashion, something along the lines of no longer downloading a toolchain for these builds but still expecting one because the artifact builds are picking up the wrong mozconfig.

I'll verify, but this shouldn't break people trying to do an artifact beta build locally.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Updating the summary to better reflect the situation here (that this is due to how the uplift simulations are run and not likely a real bug that needs attention).

Comment 6

[Ryan VanderMeulen [:RyanVM]]

The bustage was real.
https://treeherder.mozilla.org/logviewer.html#?job_id=131168581&repo=mozilla-beta&lineNumber=1212

Comment 7

[Mike Hommey [:glandium]]

Comment 1 still applies.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

10:07:04 PM - glandium: RyanVM: just add a run-on-projects to the taskcluster definition
10:07:54 PM - glandium: I can review such a change, that'll increase your chances of landing it soon, because if I write the patch, I don't know when it's going to be reviewed

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Attachment: only run artifact builds on trunk & try

Comment 10

[Gregory Szorc [:gps]]

I'm not super keen on dropping these builds on Beta since we do support artifact builds on Beta. But if this makes 57 release machinery happy, let's land it.

As glandium said, we likely don't break artifact builds on Beta due to build system work because all meaningful changes happen on trunk, where we do have CI coverage. So I'm not too worried.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/573d2347f3aa

Comment 12

[Chris Manchester (limited bugmail, email directly)]

If we do end up wanting artifact builds on beta, I believe our current issue is the mozconfig getting overriden in mozharness, which we could fix with an entry around here: http://searchfox.org/mozilla-central/rev/05c4c3bc0cfb9b0fc66bdfc8c47cac674e45f151/testing/mozharness/configs/builds/branch_specifics.py#77

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/573d2347f3aa