Closed
Bug 1389999
Opened 7 years ago
Closed 7 years ago
test_refresh_firefox.py is going to permafail when Gecko 57 merges to Beta on 2017-09-18
Categories
(Firefox :: Migration, defect)
Tracking
()
VERIFIED
FIXED
Firefox 57
People
(Reporter: RyanVM, Assigned: lchang)
References
Details
Attachments
(1 file)
Bug 1389999 - Check the existence of ProfileStorage before running tests in test_refresh_firefox.py.
59 bytes,
text/x-review-board-request
|
MattN
:
review+
|
Details |
[Tracking Requested - why for this release]: Permafailing Marionette tests on the next merge day. Henrik, can you please take a look? Feel free to redirect as needed, of course :) https://treeherder.mozilla.org/logviewer.html#?job_id=122811603&repo=try TEST-UNEXPECTED-ERROR | test_refresh_firefox.py TestFirefoxRefresh.testReset | JavascriptException: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXPCComponents_Utils.import]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: test_refresh_firefox.py :: <TOP_LEVEL> :: line 6" data: no]
Flags: needinfo?(hskupin)
Updated•7 years ago
|
Component: Marionette → Migration
Flags: needinfo?(hskupin)
Product: Testing → Firefox
Comment 1•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #0) > Henrik, can you please take a look? Feel free to redirect as needed, of > course :) Gijs or another Firefox dev should have a look at this test given that it's maintained by them.
Flags: needinfo?(gijskruitbosch+bugs)
Comment 2•7 years ago
|
||
Matt, looks like either the test should check if form autofill is enabled before trying to use the JSM, or we should ensure we ship with 57.
Blocks: 1371195
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(MattN+bmo)
Comment 3•7 years ago
|
||
Salient bit of info from the log so Matt doesn't have to dig: [task 2017-08-13T02:14:53.160709Z] 02:14:53 INFO - stacktrace: [task 2017-08-13T02:14:53.161417Z] 02:14:53 INFO - execute_script @test_refresh_firefox.py, line 368 [task 2017-08-13T02:14:53.162155Z] 02:14:53 INFO - inline javascript, line 6 [task 2017-08-13T02:14:53.162953Z] 02:14:53 INFO - src: " global.profileStorage = Cu.import("resource://formautofill/ProfileStorage.jsm", {}).profileStorage;" [task 2017-08-13T02:14:53.163605Z] 02:14:53 INFO - Stack: [task 2017-08-13T02:14:53.164442Z] 02:14:53 INFO - @test_refresh_firefox.py:6:35 [task 2017-08-13T02:14:53.165248Z] 02:14:53 INFO - @test_refresh_firefox.py:0:2 [task 2017-08-13T02:14:53.166148Z] 02:14:53 INFO - evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:165:13 [task 2017-08-13T02:14:53.166883Z] 02:14:53 INFO - evaluate.sandbox@chrome://marionette/content/evaluate.js:116:17 [task 2017-08-13T02:14:53.167718Z] 02:14:53 INFO - GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1060:14 [task 2017-08-13T02:14:53.168487Z] 02:14:53 INFO - GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:962:27 [task 2017-08-13T02:14:53.169156Z] 02:14:53 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:331:42
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(lchang)
Assignee | ||
Comment 4•7 years ago
|
||
Formautofill is going to be enabled on beta soon once bug 1390433 lands. It is supposed to fix this test. I'll take care of this. Keep NI for the reminder.
Comment 5•7 years ago
|
||
Putting back ni for Luke given that it got accidentally removed.
Flags: needinfo?(MattN+bmo) → needinfo?(lchang)
Assignee | ||
Comment 6•7 years ago
|
||
Oh! Yes, it is. Thanks.
Comment 7•7 years ago
|
||
Putting back needinfo for myself since I was going to fix this…
Flags: needinfo?(MattN+bmo)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
I end up trying to check the existence of Form Autofill modules before running tests. Not sure if I'm in the right way though.
Flags: needinfo?(lchang)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8900596 [details] Bug 1389999 - Check the existence of ProfileStorage before running tests in test_refresh_firefox.py. https://reviewboard.mozilla.org/r/172018/#review177616
Attachment #8900596 -
Flags: review?(MattN+bmo) → review+
Updated•7 years ago
|
Flags: needinfo?(MattN+bmo)
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b8691400db01 Check the existence of ProfileStorage before running tests in test_refresh_firefox.py. r=MattN
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8691400db01
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Reporter | ||
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/54f1be40a355
status-firefox56:
--- → fixed
This is fixed, no need to track it.
You need to log in
before you can comment on or make changes to this bug.
Description
•