Closed Bug 1389999 Opened 2 years ago Closed 2 years ago

test_refresh_firefox.py is going to permafail when Gecko 57 merges to Beta on 2017-09-18

Categories

(Firefox :: Migration, defect, critical)

Unspecified
All
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox56 --- fixed
firefox57 - verified

People

(Reporter: RyanVM, Assigned: lchang)

References

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing Marionette tests on the next merge day.

Henrik, can you please take a look? Feel free to redirect as needed, of course :)

https://treeherder.mozilla.org/logviewer.html#?job_id=122811603&repo=try

TEST-UNEXPECTED-ERROR | test_refresh_firefox.py TestFirefoxRefresh.testReset | JavascriptException: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXPCComponents_Utils.import]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: test_refresh_firefox.py :: <TOP_LEVEL> :: line 6" data: no]
Flags: needinfo?(hskupin)
Component: Marionette → Migration
Flags: needinfo?(hskupin)
Product: Testing → Firefox
(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)
> Henrik, can you please take a look? Feel free to redirect as needed, of
> course :)

Gijs or another Firefox dev should have a look at this test given that it's maintained by them.
Flags: needinfo?(gijskruitbosch+bugs)
Matt, looks like either the test should check if form autofill is enabled before trying to use the JSM, or we should ensure we ship with 57.
Blocks: 1371195
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(MattN+bmo)
Salient bit of info from the log so Matt doesn't have to dig:

[task 2017-08-13T02:14:53.160709Z] 02:14:53     INFO - stacktrace:
[task 2017-08-13T02:14:53.161417Z] 02:14:53     INFO - 	execute_script @test_refresh_firefox.py, line 368
[task 2017-08-13T02:14:53.162155Z] 02:14:53     INFO - 	inline javascript, line 6

[task 2017-08-13T02:14:53.162953Z] 02:14:53     INFO - 	src: "          global.profileStorage = Cu.import("resource://formautofill/ProfileStorage.jsm", {}).profileStorage;"

[task 2017-08-13T02:14:53.163605Z] 02:14:53     INFO - 	Stack:
[task 2017-08-13T02:14:53.164442Z] 02:14:53     INFO - 	@test_refresh_firefox.py:6:35
[task 2017-08-13T02:14:53.165248Z] 02:14:53     INFO - 	@test_refresh_firefox.py:0:2
[task 2017-08-13T02:14:53.166148Z] 02:14:53     INFO - 	evaluate.sandbox/promise<@chrome://marionette/content/evaluate.js:165:13
[task 2017-08-13T02:14:53.166883Z] 02:14:53     INFO - 	evaluate.sandbox@chrome://marionette/content/evaluate.js:116:17
[task 2017-08-13T02:14:53.167718Z] 02:14:53     INFO - 	GeckoDriver.prototype.execute_@chrome://marionette/content/driver.js:1060:14
[task 2017-08-13T02:14:53.168487Z] 02:14:53     INFO - 	GeckoDriver.prototype.executeScript@chrome://marionette/content/driver.js:962:27
[task 2017-08-13T02:14:53.169156Z] 02:14:53     INFO - 	TaskImpl_run@resource://gre/modules/Task.jsm:331:42
Flags: needinfo?(lchang)
Formautofill is going to be enabled on beta soon once bug 1390433 lands. It is supposed to fix this test. I'll take care of this. Keep NI for the reminder.
Assignee: nobody → lchang
Depends on: 1390433
Flags: needinfo?(lchang)
Putting back ni for Luke given that it got accidentally removed.
Flags: needinfo?(MattN+bmo) → needinfo?(lchang)
Oh! Yes, it is. Thanks.
Putting back needinfo for myself since I was going to fix this…
Flags: needinfo?(MattN+bmo)
I end up trying to check the existence of Form Autofill modules before running tests. Not sure if I'm in the right way though.
Flags: needinfo?(lchang)
Comment on attachment 8900596 [details]
Bug 1389999 - Check the existence of ProfileStorage before running tests in test_refresh_firefox.py.

https://reviewboard.mozilla.org/r/172018/#review177616
Attachment #8900596 - Flags: review?(MattN+bmo) → review+
Flags: needinfo?(MattN+bmo)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b8691400db01
Check the existence of ProfileStorage before running tests in test_refresh_firefox.py. r=MattN
https://hg.mozilla.org/mozilla-central/rev/b8691400db01
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Status: RESOLVED → VERIFIED
This is fixed, no need to track it.
You need to log in before you can comment on or make changes to this bug.