Closed Bug 1390016 Opened 3 years ago Closed 3 years ago

browser_all_files_referenced.js is going to permafail when Gecko 57 merges to Beta on 2017-09-20 (filters.svg)

Categories

(Toolkit :: Themes, defect, critical)

Unspecified
All
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 - verified

People

(Reporter: RyanVM, Assigned: ntim)

Details

Attachments

(1 file)

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

Only affects Linux and Windows, presumably because toolkit/themes/osx/global/preferences.css still references it. Tim, can you please take a look?

https://treeherder.mozilla.org/logviewer.html#?job_id=122810496&repo=try

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://global/skin/filters.svg
Flags: needinfo?(ntim.bugs)
I can fix this, however I wonder why this is only happening with the beta merge. It should already be happening without it.
This failure is pretty noisy in the Try runs, so a fix would be much appreciated :)
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Flags: needinfo?(ntim.bugs)
(In reply to Tim Nguyen :ntim from comment #1)
> I can fix this, however I wonder why this is only happening with the beta
> merge. It should already be happening without it.

I'm guessing flyweb is only enabled in Nightly.
Comment on attachment 8898125 [details]
Bug 1390016 - Remove toolkit/themes/shared/filters.svg.

https://reviewboard.mozilla.org/r/169470/#review174814
Attachment #8898125 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4dfc41c7dad1
Remove toolkit/themes/shared/filters.svg. r=dao
(In reply to Dão Gottwald [::dao] from comment #5)
> (In reply to Tim Nguyen :ntim from comment #1)
> > I can fix this, however I wonder why this is only happening with the beta
> > merge. It should already be happening without it.
> 
> I'm guessing flyweb is only enabled in Nightly.

Ah, right, the flyweb pref is disabled on Nightly, but flyweb is still packaged: https://dxr.mozilla.org/mozilla-central/source/browser/extensions/moz.build#22
https://hg.mozilla.org/mozilla-central/rev/4dfc41c7dad1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.