1390032 - "Restart to update" panel banner UI description is deceptive for private windows (implies they will be restored, but that isn't the case)

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Waqas Hussain]

Attachment: restart-to-update-panel.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce:

No particular steps, just the "Restart to update Firefox" panel banner UI popped up without me doing anything. Screenshot attached.


Actual results:

The UI had the message "After a quick restart, Firefox will restore all your open tabs and windows.". This is deceptive as the focused window was a private browsing window, and my assumption is that private windows would not be restored. I chose not to test this theory as I do not want to lose that private window accidentally at this time.


Expected results:

If the user has private windows open, the messaging should be explicit about whether private windows would be restored or not.

Comment 1

[Robert Strong (they/them - no direct email)]

Bram, can I get your input on this? Thanks

Comment 2

[Bram Pitoyo [:bram]]

Sorry for the overdue reply, as I’ve just returned from PTO on Monday.

There are two possible solutions here:

1. If on Private Window, don’t show this dialogue
  * Will this be problematic? For example, what if I set Firefox to always use Private Browsing mode?

2. If on Private Window, modify the message so it says something like this:

> Restart to update Firefox.
>
> Firefox will close all your Private Tabs and Windows.
>
> [Not Now] [Close and Restart]


What do you think?

Comment 3

[Robert Strong (they/them - no direct email)]

It is possible to have both private and regular tabs and windows. The regular tabs and windows will be restored and the private ones will not. Changing the strings as you suggested would have the opposite issue of restoring the regular tabs and windows while only informing the client that private tabs and windows won't be restored. This UI can also be shown on a regular window when there are other windows using private browsing. It would be better to either have a more generic message that avoids speaking of restoring tabs and windows if we think most clients already understand this or barring that a more specific message that covers both. I haven't thought of a more generic message but a more specific message might be.

After a quick restart, Firefox will restore all your open tabs and windows that are not private.

Comment 4

[Bram Pitoyo [:bram]]

That’s a very important concern, and I agree that a more generic message will avoid the problem.

Does this slight modification make it clearer?

> After a quick restart, Firefox will restore all your open tabs and windows that are not in Private Browsing mode.
>
> [Not Now] [Restart and Restore]

If so, then I think that we’re ready to ship it.

Comment 5

[Robert Strong (they/them - no direct email)]

That works for me.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76e8870c843e
make it clear in the update doorhanger text that private browser windows and tabs are not restored. r=dothayer

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/76e8870c843e