Closed Bug 1390038 Opened 2 years ago Closed 2 years ago

about:rights shows XML parsing error again

Categories

(Firefox for Android :: General, defect)

56 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox56 blocking verified
firefox57 --- verified

People

(Reporter: cnevinchen, Assigned: cnevinchen)

Details

(Whiteboard: [FNC][SPT57.2][INT][SP=X, 1])

Attachments

(1 file)

This bug is to fix Bug 1377742.
Comment on attachment 8896850 [details]
Bug 1390038 - Fix xml parsing error.

https://reviewboard.mozilla.org/r/168146/#review173542
Attachment #8896850 - Flags: review?(dao+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/2d460c909a22
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Bug 1377742 was reported in 56 and I marked it as a release blocker.  I think this would be an embarrassing error to ship to release on 56. 

Can you please request uplift to beta for this patch? Thanks.
Comment on attachment 8896850 [details]
Bug 1390038 - Fix xml parsing error.

Approval Request Comment
[Feature/Bug causing the regression]:1390038
[User impact if declined]:user will see a broken about page.
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:no
[Why is the change risky/not risky?]: Remove a non-need line to remove error 
[String changes made/needed]:no
Attachment #8896850 - Flags: approval-mozilla-beta?
Comment on attachment 8896850 [details]
Bug 1390038 - Fix xml parsing error.

Fix a broken about page. Beta56+.
Attachment #8896850 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on the latest Beta 56.0b5 build
Whiteboard: [FNC][SPT57.2][INT]
Whiteboard: [FNC][SPT57.2][INT] → [FNC][SPT57.2][INT][SP=X, 1]
Verified as fixed in build 57.0a1 - 09/04.
Device: Honor 8 (Android 7.0).
You need to log in before you can comment on or make changes to this bug.