Closed
Bug 1390038
Opened 7 years ago
Closed 7 years ago
about:rights shows XML parsing error again
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox56blocking verified, firefox57 verified)
RESOLVED
FIXED
Firefox 57
People
(Reporter: cnevinchen, Assigned: cnevinchen)
Details
(Whiteboard: [FNC][SPT57.2][INT][SP=X, 1])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
dao
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
This bug is to fix Bug 1377742.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8896850 [details] Bug 1390038 - Fix xml parsing error. https://reviewboard.mozilla.org/r/168146/#review173542
Attachment #8896850 -
Flags: review?(dao+bmo) → review+
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d460c909a22 Fix xml parsing error. r=dao
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2d460c909a22
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 6•7 years ago
|
||
Bug 1377742 was reported in 56 and I marked it as a release blocker. I think this would be an embarrassing error to ship to release on 56. Can you please request uplift to beta for this patch? Thanks.
status-firefox56:
--- → affected
tracking-firefox56:
--- → blocking
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8896850 [details] Bug 1390038 - Fix xml parsing error. Approval Request Comment [Feature/Bug causing the regression]:1390038 [User impact if declined]:user will see a broken about page. [Is this code covered by automated tests?]:no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]:no [Is the change risky?]:no [Why is the change risky/not risky?]: Remove a non-need line to remove error [String changes made/needed]:no
Attachment #8896850 -
Flags: approval-mozilla-beta?
Comment 8•7 years ago
|
||
Comment on attachment 8896850 [details] Bug 1390038 - Fix xml parsing error. Fix a broken about page. Beta56+.
Attachment #8896850 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/9832bd5eb39d
Comment 10•7 years ago
|
||
Verified as fixed on the latest Beta 56.0b5 build
Updated•7 years ago
|
Whiteboard: [FNC][SPT57.2][INT]
Assignee | ||
Updated•7 years ago
|
Whiteboard: [FNC][SPT57.2][INT] → [FNC][SPT57.2][INT][SP=X, 1]
Comment 11•7 years ago
|
||
Verified as fixed in build 57.0a1 - 09/04. Device: Honor 8 (Android 7.0).
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•