Fix the "Settings" button string under Permissions in about:preferences#privacy by appending ellipses

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Preferences
P1
normal
VERIFIED FIXED
10 months ago
7 months ago

People

(Reporter: prathiksha, Assigned: prathiksha)

Tracking

unspecified
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox57 verified)

Details

(Whiteboard: [photon-preference])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Updated

10 months ago
Assignee: nobody → prathikshaprasadsuman
Comment hidden (mozreview-request)

Comment 2

10 months ago
mozreview-review
Comment on attachment 8896879 [details]
Bug 1390049 - Fix the Settings button string under Permissions in about:preferences#privacy by appending ellipses.

https://reviewboard.mozilla.org/r/168168/#review173328

LGTM. Thanks:)
Attachment #8896879 - Flags: review?(rchien) → review+
Flags: qe-verify+
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage]
(Assignee)

Updated

10 months ago
Keywords: checkin-needed

Comment 3

10 months ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f011eb6ab266
Fix the Settings button string under Permissions in about:preferences#privacy by appending ellipses. r=rickychien
Keywords: checkin-needed
(Assignee)

Updated

10 months ago
Status: NEW → ASSIGNED

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f011eb6ab266
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

10 months ago
Blocks: 1381401

Updated

10 months ago
Whiteboard: [photon-preference][triage] → [photon-preference]

Comment 5

10 months ago
I'm trying to verify this bug on Nightly 57 but I can't figure out what is the expected behavior here.
Could you please provide me with the expected behavior?

Thanks.
Flags: needinfo?(prathikshaprasadsuman)
(Assignee)

Comment 6

10 months ago
Expected behavior - The 'Settings' buttons label in about:preferences#privacy under the 'Permissions' heading should be "Settings...". 

The label was "Settings" initially and was changed to "Settings..." with the ellipses.
Flags: needinfo?(prathikshaprasadsuman)

Comment 7

10 months ago
Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified

Updated

7 months ago
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.