Closed
Bug 1390064
Opened 7 years ago
Closed 7 years ago
The IgnoreTrivials overload taking an Expr in Utils.h should use cast_or_null
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: tbourvon, Assigned: tbourvon, Mentored)
Details
Attachments
(1 file)
|
762 bytes,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
While building Firefox I noticed a compiler error, which is due to IgnoreTrivials using cast<> and not cast_or_null<>. This patches fixes this.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8896907 -
Flags: review?(michael)
|
||
Updated•7 years ago
|
Attachment #8896907 -
Flags: review?(michael) → review+
|
||
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88b8929601583c87b906f75c452e55c2bcaf178f Bug 1390064 - Fix IgnoreTrivials in Utils.h by changing cast to cast_or_null r=mystor
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/88b892960158 Fix IgnoreTrivials in Utils.h by changing cast to cast_or_null r=mystor
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/88b892960158
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
Tristan, it looks like you are the assignee on this bug, but under a different email. Are you still working on this bug? If not, would you please unassign yourself?
Flags: needinfo?(tristanbourvon)
|
||
Comment 6•5 years ago
|
||
Sorry for the spurious NI request, missed that this bug had been resolved.
Flags: needinfo?(tristanbourvon)
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•